[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: oldstable: mt-daapd update addressing #555231



"Adam D. Barratt" <adam@adam-barratt.org.uk> wrote:

Hi,

> a) that the current embedded copy of prototype is an unmodified version
> from prototype upstream and

Virtually unmodified, only a harmless change was done to the copy
shipped with mt-daapd.

    Make prototype.js first test for XMLHttprequest object
    and then the IE active-x thingies. This forces IE 7 to use
    the native XMLHttprequest object. (and debugging on gecko
    browsers easier)

------------------------ admin-root/lib-js/prototype.js ------------------------
index e9ccd3c..19a577c 100644
@@ -549,9 +549,9 @@ var $R = function(start, end, exclusive) {
 var Ajax = {
   getTransport: function() {
     return Try.these(
+      function() {return new XMLHttpRequest()},
       function() {return new ActiveXObject('Msxml2.XMLHTTP')},
-      function() {return new ActiveXObject('Microsoft.XMLHTTP')},
-      function() {return new XMLHttpRequest()}
+      function() {return new ActiveXObject('Microsoft.XMLHTTP')}
     ) || false;
   },

> b) the package has been tested to ensure it operates correctly with the
> new version of prototype on the relevant Debian release; this is
> particularly important for etch updates, as there are likely to be a
> maximum of two further etch point releases.

My tests show that the web interface behaves as good as always; besides,
the portion of the web interface that's deemed stable hasn't seen much
changes between the version included in Etch and subsequent
versions. The experimental parts of the web interface are not
shipped/not used/not reachable/not usable anyway.

JB.

-- 
 Julien BLACHE <jblache@debian.org>  |  Debian, because code matters more 
 Debian & GNU/Linux Developer        |       <http://www.debian.org>
 Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169 


Reply to: