Pre approval to fix for Bug#519719: /usr/share/doc/base-files/remove-base doesn't remove correct files (fwd)

[Santiago Vila <sanvila@unex.es>]

Hello stable release managers.

This code is obsolete and I plan to remove it from base-files in squeeze,
but before that I would like to fix it in etch and lenny using
{etch,lenny}-proposed-updates.

The patch would be like this:


diff -ru base-files-5.original/debian/remove-base base-files-5/debian/remove-base
--- base-files-5.original/debian/remove-base  2002-02-08 16:39:13.000000000 +0100
+++ base-files-5/debian/remove-base   2009-03-27 13:55:04.055412812 +0100
@@ -1,6 +1,6 @@
 #!/bin/sh
 set -e
-rm -f /var/lib/dpkg/base.*
+rm -f /var/lib/dpkg/info/base.*
 cd /var/lib/dpkg
 if grep -q "^Package: base$" status; then
 cp status status.bak


i.e. the patch is a one liner.

Do I have your approval for this?

---------- Forwarded message ----------
From: Peter Maydell <pmaydell@chiark.greenend.org.uk>
To: submit@bugs.debian.org
Date: Sat, 14 Mar 2009 16:31:30 +0000
Subject: Bug#519719: /usr/share/doc/base-files/remove-base doesn't remove
    correct files
Resent-Sender: Santiago Vila <sanvila@master.debian.org>

Package: base-files
Version: 5

/usr/share/doc/base-files/README.base says that one of the things
that must be done to remove the old 'base' package is:
# 4. Remove all the files matching "/var/lib/dpkg/info/base.*".

However, the provided shell script /usr/share/doc/base-files/remove-base
does this:
  rm -f /var/lib/dpkg/base.*

The effect is that it silently doesn't remove the files it ought to,
and base-files' postinst will continue to nag about the existence
of the base package.

I only noticed this when I recently upgraded to lenny and got
nagged at when I knew I'd dealt with 'base' last upgrade cycle...

-- PMM