[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please binNMU librsvg



On Sun, Aug 24, 2008 at 11:21:52AM -0700, Steve Langasek wrote:
> On Sun, Aug 24, 2008 at 10:13:07AM +0200, Mike Hommey wrote:
> 
> > Please binNMU librsvg against libxml2 2.6.32.dfsg-2+lenny1, due to bug
> > #496125.
> 
> Can you elaborate on why a binNMU is appropriate here, please?  If this is
> ABI breakage in libxml2, that's a serious bug that should be fixed in that
> package, not papered over with binNMUs.

librsvg is abusing libxml2 headers and should be using the API it has
available instead of malloc'ing xmlEntitys.

See https://bugzilla.redhat.com/show_bug.cgi?id=459830#c4

Also note that there is a patch that keeps binary compatibility by
abusing a field in the structure instead of growing it, which I got
aware of after sending the request for binNMU. While it is a good
idea for stable, I'm not sure it is the best course of action for
Lenny, since this struct growing is still going to happen anyway
(for next libxml2 release).

When I find some time, I will go through libxml2 rdepends to check for
possible other abuses of this struct, but I'm pretty confident librsvg
is the only one.

> And anyway, no, libxml2 2.6.32.dfsg-2+lenny1 isn't in testing (or
> testing-proposed-updates), so binNMUs into testing are not exactly possible
> at present.

:-/

Mike


Reply to: