[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Pre-approval of bugfix release of bindfs, version 1.8



Hi release team!

Upstream of bindfs package has just released version 1.8, which fixed following issue:
http://code.google.com/p/bindfs/issues/detail?id=4&can=1. It was not reported in BTS. I
would treat severity of this bug as important.

Changes between 1.7 (in testing) and 1.8 are tiny:

 bindfs.c |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

Full diff is attached.

Can bindfs 1.8 go to testing?

-- 
Eugene V. Lyubimkin aka JackYF, Ukrainian C++ developer.
diff -ru bindfs-1.7/src/bindfs.c bindfs-1.8/src/bindfs.c
--- bindfs-1.7/src/bindfs.c	2008-07-08 00:01:19.000000000 +0300
+++ bindfs-1.8/src/bindfs.c	2008-08-17 15:41:25.000000000 +0300
@@ -836,7 +836,13 @@
 static void atexit_func()
 {
     permchain_destroy(settings.permchain);
+    settings.permchain = NULL;
     permchain_destroy(settings.create_permchain);
+    settings.create_permchain = NULL;
+    free(settings.mirrored_users);
+    settings.mirrored_users = NULL;
+    free(settings.mirrored_members);
+    settings.mirrored_members = NULL;
 }
 
 enum OptionKey {
@@ -932,15 +938,11 @@
         char *create_for_group;
         char *create_with_perms;
         int no_allow_other;
-    } od = {NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0};
+    } od = {NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0};
 
     #define OPT2(one, two, key) \
-            {one, -1, key}, \
-            {two, -1, key}
-    #define OPT3(one, two, three, key) \
-            {one, -1, key}, \
-            {two, -1, key}, \
-            {three, -1, key}
+            FUSE_OPT_KEY(one, key), \
+            FUSE_OPT_KEY(two, key)
     #define OPT_OFFSET2(one, two, offset, key) \
             {one, offsetof(struct OptionData, offset), key}, \
             {two, offsetof(struct OptionData, offset), key}
@@ -1149,8 +1151,5 @@
     fuse_opt_free_args(&args);
     close(settings.mntsrc_fd);
 
-    free(settings.mirrored_users);
-    free(settings.mirrored_members);
-
     return fuse_main_return;
 }

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: