[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: r-cran-r.devices

On Thu 21 Oct 2021 02:32:45 AM EDT, Nilesh Patra <nilesh@onenetbeyond.org> wrote:

On 10/21/21 6:30 AM, Torrance, Douglas wrote:

Hi everyone,
I've just packaged R.devices, which would be headed for the NEW
queue.
Would anyone be able to review/sponsor?


I will sponsor, but see below


Great, thank you!


 > https://salsa.debian.org/r-pkg-team/r-cran-r.devices
Note: There's a little bit of a chicken-and-egg situation here. R.devices 
requires R.rsp (which is not in Debian yet)


Do you also need sponsoring for r-cran-r.rsp?


Yes, eventually, but after R.devices is in unstable.


to build its vignettes, but R.rsp
requires R.devices to build its vignettes!  So currently I'm just using the
pre-built vignettes.


(Assuming the answer to above is yes)

I think circular "Build-"depends are fine, many packages have it as a matter of fact -- one good example I know
is node-babel7 (babel is a very popular JS framework) having a B-D on itself
however what is not okay is cirular "Depends"

But that said, we should try avoiding circular B-D wherever possible, and vigenettes are not that important
to warrant for such a circular B-D, so I have two solutions/workarounds:

1. Don't use the upstream pre-builds, rather write a simple script, and generate the vigenettes "locally",
and move them to a dir say debian/resources, then simply install these pre-builds during dh_auto_install.
and, mention what you did in d/README.Source

The only demerit is that with each new update, you will have to keep running the script to regenerate these vigenettes.


I've just implemented something like this now.  The source package now includes
a .tex file, generated locally using R.rsp, that is then used during build to
generate the final pdf vignette.


2. Prune vigenettes altogether, don't vendor them at all -- I don't think they are very important, so you
can take a pass here.


I'm a big fan of documentation, so I'm going to try to avoid this option if
at all possible.  :)


I don't have any problems with upstream pre-built vigenettes either, but then it's likely to be rejected.

Please consider doing either of the two, and let me know when it's ready.


I don't think it's quite ready yet -- I just noticed some .rds files for a test
that probably should be generated during build, too -- but I'll ping you when I
think it's good to go.

Thanks!
Doug

Attachment: signature.asc
Description: PGP signature

Reply to: