[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#977275: kdeconnect FTCBFS: error parsing cmake expression containing unquoted variable



Source: kdeconnect
Version: 20.08.3-1
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

kdeconnect fails to cross build from source. plugins/CMakeLists.txt
contains a condition that contains an unquoted ${CMAKE_SYSTEM_VERSION}.
Since the toolchain does not set this optional variable, it evaluates to
nothing rather than an empty string and breaks parsing the condition
(which is only relevant to windows). Please quote the variable to allow
evaluating the expression without having to define the variable. Doing
so makes kdeconnect cross buildable. I'm attaching a patch for your
convenience.

Helmut
--- kdeconnect-20.08.3.orig/plugins/CMakeLists.txt
+++ kdeconnect-20.08.3/plugins/CMakeLists.txt
@@ -17,7 +17,7 @@
 
 if(NOT SAILFISHOS)
     add_subdirectory(sendnotifications)
-    if((WIN32 AND MSVC AND (${CMAKE_SYSTEM_VERSION} VERSION_GREATER_EQUAL 10.0.17763.0)) OR NOT WIN32)
+    if((WIN32 AND MSVC AND ("${CMAKE_SYSTEM_VERSION}" VERSION_GREATER_EQUAL 10.0.17763.0)) OR NOT WIN32)
         add_subdirectory(mpriscontrol)
     endif()
     add_subdirectory(photo)

Reply to: