[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#857994: qtwebchannel-opensource-src: Please do not depend on npm



Control: tags -1 patch

@ BSP Mönchengladbach

On Fri, 17 Mar 2017 00:40:28 +0100 Jérémy Lal <kapouer@melix.org> wrote:
> Would qtwebchannel5-examples be broken without npm ?

Two examples seem to need npm when one wants to see the example in
action. However, I think that without npm from Debian, the examples are
still valuable to read and there are multiple other examples present as
well.

I propose the attached debdiff to fix this dependency, which demotes the
dependency to suggests. Please let me know if you want me to upload as
attached.

Paul
diff -Nru qtwebchannel-opensource-src-5.7.1/debian/changelog qtwebchannel-opensource-src-5.7.1/debian/changelog
--- qtwebchannel-opensource-src-5.7.1/debian/changelog	2016-12-16 12:49:43.000000000 +0100
+++ qtwebchannel-opensource-src-5.7.1/debian/changelog	2017-03-18 12:37:30.000000000 +0100
@@ -1,3 +1,11 @@
+qtwebchannel-opensource-src (5.7.1-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Demote qtwebchannel5-examples dependency on npm to suggest to enable
+    removal of npm in testing (Closes: #857994)
+
+ -- Paul Gevers <elbrus@debian.org>  Sat, 18 Mar 2017 12:37:30 +0100
+
 qtwebchannel-opensource-src (5.7.1-1) unstable; urgency=medium
 
   [ Sandro Knauß ]
diff -Nru qtwebchannel-opensource-src-5.7.1/debian/control qtwebchannel-opensource-src-5.7.1/debian/control
--- qtwebchannel-opensource-src-5.7.1/debian/control	2016-12-16 12:45:28.000000000 +0100
+++ qtwebchannel-opensource-src-5.7.1/debian/control	2017-03-18 12:37:30.000000000 +0100
@@ -68,10 +68,10 @@
 Multi-Arch: same
 Depends: libqt5webchannel5 (= ${binary:Version}),
          nodejs [!armel !powerpc],
-         npm [!armel !powerpc],
          ${misc:Depends},
          ${shlibs:Depends}
 Pre-Depends: ${misc:Pre-Depends}
+Suggests: npm [!armel !powerpc],
 Description: Web communication library for Qt - Examples
  Qt WebChannel enables peer-to-peer communication between the host (QML/C++
  application) and the client (HTML/JavaScript application). The transport

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: