[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#854260: sddm: Please remove Conflicts= and OnFailure= from sddm.service file



severity 854260 serious
thanks

On Sun, 05 Feb 2017 16:44:43 +0100 Laurent Bigonville <bigon@debian.org> wrote:
>
> Hi,
>
> The debian/sddm.service file contains the following lines:
>
> Conflicts=plymouth-quit-wait.service
> After=systemd-user-sessions.service plymouth-start.service plymouth-quit-wait.service
> OnFailure=plymouth-quit.service
>
> For me the Conflicts= (and the OnFailure=) doesn't make any sense. The
> gdm.service file contains these line too but only because GDM takes care
> himself of stopping plymouth. sddm should just wait that plymouth
> is stopped here and nothing else.
>
> The OnFailure= is also redundant here if the Conflicts= is removed as
> the plymouth-quit.service will be executed anyway.
>
> Upstream ships a file in services/sddm.service.in, with
> After=plymouth-quit.service (like GDM), any reason you have modified
> this?

Thinking about this again, the Conflicts= statement could actually causes issues for other packages that are declaring a dependency against that service.

I'm raising the severity to serious


Reply to: