Hi, Thanks for taking care of libkolab, I've made a quick review of the package, mostly checking the differences with the Debian package. The list is long, but I think most of the points are easy to fix. General package: Please rebase on top of git://git.debian.org/git/pkg-kolab/libkolab.git, avoid deleting changelog entries. And avoid entries that claim being uploaded to unstable if they weren't. To test the package libkolabxml (>= 1.0) is needed. debian/changelog: * urgency=medium is the new default debian/control: * Standards-Version should be 3.9.5 * Please maintain the vcs-fields * libkolab0 declares libcalendaring as a dependency, this is not the case, right? * There is no entry for libkolab-kde0, but there are some install and lintian-overrides and shlibs files for it. * There is no entry for libkolab-kde-dev, but there is and install file for it, also this install file installs almost the same files as libkolab-dev. * There is no entry for php-kolab-kde-dev, but there is and install file for it, also this install file installs the same files as php-kolab-dev. * There is no entry for python-kolab-kde, but there is and install file for it, also this install file installs the same files as python-kolab. debian/copyright: * Please maintain the blocks for debian/* and for cmake/* debian/libkolab0.shlibs: * If you are adding this file I would say it's >= 0.5 But is the ABI of libkolab0 0.5 is backwards compatible with 0.4? Also, this is about the same as using dh_makeshlibs -V debian/php-kolab.install: * I wouldn't use usr/lib/php5/*/*.so and would prefer something like: usr/lib/php5/*/kolab*.so instead to avoid a filename clashes (I haven't checked the filenames produced). debian/php-kolab.postinst: * Indentation mixes tabs and spaces debian/php-kolab.postrm: * indentation mixes tabs and spaces debian/php-kolab.prerm: * Changes the interpreter to bash, where is the bashism? * Indentation mixes tabs and spaces debian/python-kolab.install: * I wouldn't use usr/lib*/python*/*-packages/* but something that avoid filenames clashes as: usr/lib*/python*/*-packages/kolab/ debian/rules: * About: export DH_VERBOSE=1 export DH_OPTIONS=-v shouldn't be forced, so comment them before a release. * About: dh_makeshlibs -- -c2 are you sure that using the default (-c1) is not enough? debian/usr/share/php5/kolab/kolab.ini: * Ok, now I'm really confused, what's the deal with calendaring? is there a phpcalendaring even if there is no libcalendaring? Thanks again. Happy hacking, -- "Some people worry that artificial intelligence will make us feel inferior, but then, anybody in his right mind should have an inferiority complex every time he looks at a flower." -- Alan Kay Saludos /\/\ /\ >< `/
Attachment:
signature.asc
Description: Digital signature