[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#506181: [Pkg-cups-devel] Bug#506181: Various backends have the wrong permissions



Hi Chanoch,

Chanoch (Ken) Bloom [2008-11-19  8:21 -0600]:
> I decided to test this by purging and reinstalling cups. Cups worked out
> of the box. Then I went to reconfigure things the way I had been using
> CUPS (1 printer, shared with the whole subnet) by editing things in the
> KDE Printing control panel. After changing things with "Print Server ->
> Configure Server...", KDE wrote out a whole different cupsd.conf, hardly
> resembling the original. I can't figure out how that cupsd.conf is
> assigning permissions. kdeprint added the line "Group lpadmin", but the
> test backend gives uid=7(lp) gid=0(root) groups=0(root).

Ah, Group "lpadmin" is wrong. It should be SystemGroup "lpadmin",
and it shouldn't change Group.

> I guess this is a kdeprint bug rather than a cups bug, so I'm
> reassigning it. The two versions of cupsd.conf are attached.

Right, thank you!

> > I do see the issue with the serial backends. For that we probably need
> > to make the serial backend run as root.
> 
> Perhaps making the various backends SetGID (or SetUID) to the
> permissions they need would help?

I fixed it in cups now (see attached patch), will upload to
experimental and unstable.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
=== modified file 'debian/changelog'
--- debian/changelog	2008-11-20 07:53:16 +0000
+++ debian/changelog	2008-11-20 07:56:07 +0000
@@ -9,6 +9,9 @@
     backchannel EOF (select() returns "ready for read" on EOF). This
     completely broke printing with e. g. HPJetDirect. Thanks to
     Samuel Thibault for tracking down the problem! (Closes: #489045)
+  * debian/rules: Install the serial backend with 0744 permissions to make it
+    run as root, since /dev/ttyS* are root:dialout and thus not accessible as
+    user "lp". Thanks to Chanoch (Ken) Bloom. (One part of #506181)
 
  -- Martin Pitt <mpitt@debian.org>  Thu, 20 Nov 2008 08:52:00 +0100
 

=== modified file 'debian/rules'
--- debian/rules	2008-05-23 08:14:05 +0000
+++ debian/rules	2008-11-20 07:55:48 +0000
@@ -73,6 +73,10 @@
 	   install -D -m 644 debian/local/apparmor-profile debian/$(cdbs_curpkg)/etc/apparmor.d/usr.sbin.cupsd; \
 	fi
 
+	# Make the serial backend run as root, since /dev/ttyS* are
+	# root:dialout and thus not accessible as user lp
+	chmod go-x debian/$(cdbs_curpkg)/usr/lib/cups/backend-available/serial
+
 binary-post-install/libcupsimage2-dev::
 	rm -r debian/libcupsimage2-dev/usr/share/doc/libcupsimage2-dev
 	ln -s libcupsimage2 debian/libcupsimage2-dev/usr/share/doc/libcupsimage2-dev

Attachment: signature.asc
Description: Digital signature


Reply to: