[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#438952: marked as done (kdelibs: FTBFS on hurd-i386)



Your message dated Fri, 24 Aug 2007 04:17:14 +0000
with message-id <E1IOQbi-00020L-Bb@ries.debian.org>
and subject line Bug#438952: fixed in kdelibs 4:3.5.7.dfsg.1-5
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: kdelibs
Version: 4:3.5.7.dfsg.1-4
Severity: important
Tags: patch

Hi,

Kdelibs currently FTBFS because 

- on hurd-i386, the optional macro MAXPATHLEN is not defined since
there's no such hard global limit. readdir_r(), however, is known to be
limited to UCHAR_MAX on GNU/Hurd.
- on hurd-i386, the optional macro PATH_MAX is not defined either for
the same reason. The glibc version of getcwd(), however, can actually
allocate as much room as is required.

Here is a patch.

Samuel

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-xen
Locale: LANG=fr_FR@euro, LC_CTYPE=fr_FR@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

-- 
Samuel
> Allez, soyez sympa ... traduisez-lui "linux"
Linux, c'est comme le miel : c'est vachement bon mais ça attire les
mouches. En plus, ça colle aux doigts et on a du mal à s'en défaire.
-+- TP in: Guide du linuxien pervers - "Barrez vous les mouches !"
--- kdelibs-3.5.7.dfsg.1/kio/kio/kurlcompletion.cpp.orig	2007-08-21 01:20:27.125594000 +0200
+++ kdelibs-3.5.7.dfsg.1/kio/kio/kurlcompletion.cpp	2007-08-21 01:28:02.002981000 +0200
@@ -231,6 +231,9 @@
 		while ( !terminationRequested() &&
 		        (dirEntry = ::readdir( dir)))
 #else
+#if !defined(MAXPATHLEN) && defined(__GNU__)
+#define MAXPATHLEN UCHAR_MAX
+#endif
 		struct dirent *dirPosition = (struct dirent *) malloc( sizeof( struct dirent ) + MAXPATHLEN + 1 );
 		struct dirent *dirEntry = 0;
 		while ( !terminationRequested() &&
--- kdelibs-3.5.7.dfsg.1/kdoctools/meinproc.cpp.orig	2007-08-21 01:40:47.688059000 +0200
+++ kdelibs-3.5.7.dfsg.1/kdoctools/meinproc.cpp	2007-08-21 01:46:17.833610000 +0200
@@ -136,9 +136,18 @@
     }
 
     if ( args->isSet( "check" ) ) {
+#if !defined(PATH_MAX) && defined(__GLIBC__)
+        char *pwd_buffer;
+#else
         char pwd_buffer[PATH_MAX];
+#endif
         QFileInfo file( QFile::decodeName(args->arg( 0 )) );
-        if ( !getcwd( pwd_buffer, sizeof(pwd_buffer) - 1 ) ) {
+#if !defined(PATH_MAX) && defined(__GLIBC__)
+        if ( !(pwd_buffer = getcwd( NULL, 0 ) ) )
+#else
+        if ( !getcwd( pwd_buffer, sizeof(pwd_buffer) - 1 ) )
+#endif
+	{
 	     kdError() << "getcwd failed." << endl;
              return 2;
 	}
@@ -175,11 +184,18 @@
             }
             pclose( xmllint );
             chdir( pwd_buffer );
-            if ( !noout )
+            if ( !noout ) {
+#if !defined(PATH_MAX) && defined(__GLIBC__)
+                free( pwd_buffer );
+#endif
                 return 1;
+            }
         } else {
             kdWarning() << "couldn't find xmllint" << endl;
         }
+#if !defined(PATH_MAX) && defined(__GLIBC__)
+        free( pwd_buffer );
+#endif
     }
 
     xmlSubstituteEntitiesDefault(1);
--- kdelibs-3.5.7.dfsg.1/kioslave/file/file.cc.orig	2007-08-21 01:51:36.702504000 +0200
+++ kdelibs-3.5.7.dfsg.1/kioslave/file/file.cc	2007-08-21 01:55:39.362966000 +0200
@@ -1234,8 +1234,13 @@
        directories we keep as active directory. And
        as the slave runs in the background, it's hard
        to see for the user what the problem would be */
+#if !defined(PATH_MAX) && defined(__GLIBC__)
+    char *path_buffer;
+    path_buffer = getcwd(NULL, 0);
+#else
     char path_buffer[PATH_MAX];
     (void) getcwd(path_buffer, PATH_MAX - 1);
+#endif
     if ( chdir( _path.data() ) )  {
         if (errno == EACCES)
             error(ERR_ACCESS_DENIED, _path);
@@ -1261,6 +1266,9 @@
     kdDebug(7101) << "============= COMPLETED LIST ============" << endl;
 
     chdir(path_buffer);
+#if !defined(PATH_MAX) && defined(__GLIBC__)
+    free(path_buffer);
+#endif
 
     finished();
 }
--- kdelibs-3.5.7.dfsg.1/libkmid/fmout.cc.orig	2007-08-21 02:05:03.032474000 +0200
+++ kdelibs-3.5.7.dfsg.1/libkmid/fmout.cc	2007-08-21 02:08:08.281128000 +0200
@@ -127,8 +127,8 @@
 void FMOut::loadFMPatches(void)
 {
 #ifdef HAVE_OSS_SUPPORT
-  char patchesfile[PATH_MAX];
-  char drumsfile[PATH_MAX];
+  char patchesfile[strlen(FMPatchesDirectory)+7+1];
+  char drumsfile[strlen(FMPatchesDirectory)+9+1];
   int size;
   struct sbi_instrument instr;
   char tmp[60];
@@ -141,12 +141,12 @@
 
   if (opl==3)
   {
-    snprintf(patchesfile, PATH_MAX, "%s/std.o3",FMPatchesDirectory);
+    snprintf(patchesfile, sizeof(patchesfile), "%s/std.o3",FMPatchesDirectory);
     size=60;
   }
   else
   {
-    snprintf(patchesfile, PATH_MAX, "%s/std.sb",FMPatchesDirectory);
+    snprintf(patchesfile, sizeof(patchesfile), "%s/std.sb",FMPatchesDirectory);
     size=52;
   }
   fh=fopen(patchesfile,"rb");
@@ -171,11 +171,11 @@
 
   if (opl==3)
   {
-    snprintf(drumsfile, PATH_MAX, "%s/drums.o3",FMPatchesDirectory);
+    snprintf(drumsfile, sizeof(drumsfile), "%s/drums.o3",FMPatchesDirectory);
   }
   else
   {
-    snprintf(drumsfile, PATH_MAX, "%s/drums.sb",FMPatchesDirectory);
+    snprintf(drumsfile, sizeof(drumsfile), "%s/drums.sb",FMPatchesDirectory);
   }
 
   fh=fopen(drumsfile,"rb");
--- kdelibs-3.5.7.dfsg.1/kinit/lnusertemp.c.orig	2007-08-21 02:16:31.074726000 +0200
+++ kdelibs-3.5.7.dfsg.1/kinit/lnusertemp.c	2007-08-21 02:17:13.037686000 +0200
@@ -89,6 +89,9 @@
 }
 
 
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
 int build_link(const char *tmp_prefix, const char *kde_prefix)
 {
   struct passwd *pw_ent;

--- End Message ---
--- Begin Message ---
Source: kdelibs
Source-Version: 4:3.5.7.dfsg.1-5

We believe that the bug you reported is fixed in the latest version of
kdelibs, which is due to be installed in the Debian FTP archive:

kdelibs-data_3.5.7.dfsg.1-5_all.deb
  to pool/main/k/kdelibs/kdelibs-data_3.5.7.dfsg.1-5_all.deb
kdelibs-dbg_3.5.7.dfsg.1-5_amd64.deb
  to pool/main/k/kdelibs/kdelibs-dbg_3.5.7.dfsg.1-5_amd64.deb
kdelibs4-dev_3.5.7.dfsg.1-5_amd64.deb
  to pool/main/k/kdelibs/kdelibs4-dev_3.5.7.dfsg.1-5_amd64.deb
kdelibs4-doc_3.5.7.dfsg.1-5_all.deb
  to pool/main/k/kdelibs/kdelibs4-doc_3.5.7.dfsg.1-5_all.deb
kdelibs4c2a_3.5.7.dfsg.1-5_amd64.deb
  to pool/main/k/kdelibs/kdelibs4c2a_3.5.7.dfsg.1-5_amd64.deb
kdelibs_3.5.7.dfsg.1-5.diff.gz
  to pool/main/k/kdelibs/kdelibs_3.5.7.dfsg.1-5.diff.gz
kdelibs_3.5.7.dfsg.1-5.dsc
  to pool/main/k/kdelibs/kdelibs_3.5.7.dfsg.1-5.dsc
kdelibs_3.5.7.dfsg.1-5_all.deb
  to pool/main/k/kdelibs/kdelibs_3.5.7.dfsg.1-5_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 438952@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org> (supplier of updated kdelibs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 23 Aug 2007 07:24:52 +0200
Source: kdelibs
Binary: kdelibs4c2a kdelibs kdelibs4-doc kdelibs-dbg kdelibs-data kdelibs4-dev
Architecture: source amd64 all
Version: 4:3.5.7.dfsg.1-5
Distribution: unstable
Urgency: low
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Description: 
 kdelibs    - core libraries from the official KDE release
 kdelibs-data - core shared data for all KDE applications
 kdelibs-dbg - debugging symbols for kdelibs
 kdelibs4-dev - development files for the KDE core libraries
 kdelibs4-doc - developer documentation for the KDE core libraries
 kdelibs4c2a - core libraries and binaries for all KDE applications
Closes: 437414 438558 438952
Changes: 
 kdelibs (4:3.5.7.dfsg.1-5) unstable; urgency=low
 .
   +++ Changes by Ana Beatriz Guerrero Lopez:
 .
   * Add patch 48_cups13.diff to build against new CUPS 1.3.0.
     Patch by Tim Waugh. (Closes: #438558)
   * Add patch 48_hurd_support.diff to fix FTBFS on hurd-i386.
     Patch by Samuel Thibault. (Closes: #438952)
 .
   +++ Changes by Fathi Boudra:
 .
   * Move binaries to kdelibs4-dev: kconfig_compiler, ksvgtopng,
     kunittestmodrunner, makekdewidgets, preparetips.
     Allow kdelibs5-dev co-installable alongside kdelibs4c2a.
 .
   * Suggests perl-suid instead Recommends. (Closes: #437414)
Files: 
 c1d1f8c5d49f23adefab3cdb2f0048e9 1621 libs optional kdelibs_3.5.7.dfsg.1-5.dsc
 f716c13279fa8432a953d669ef52d11d 791117 libs optional kdelibs_3.5.7.dfsg.1-5.diff.gz
 fed36f144553da801212e4b367544f33 35052 libs optional kdelibs_3.5.7.dfsg.1-5_all.deb
 a6fd2f77ac600917510376bd33414fad 8675264 libs optional kdelibs-data_3.5.7.dfsg.1-5_all.deb
 d2db07473b0932948d7e7e1c1c9a6e7f 37716674 doc optional kdelibs4-doc_3.5.7.dfsg.1-5_all.deb
 b79965c2e74ea01b98327ce5fb9b3219 10757176 libs optional kdelibs4c2a_3.5.7.dfsg.1-5_amd64.deb
 67976a1ded24bcf457256f89b5a2012e 1453272 libdevel optional kdelibs4-dev_3.5.7.dfsg.1-5_amd64.deb
 c4829d77e58029b1c539710e27475f7f 26947254 libdevel extra kdelibs-dbg_3.5.7.dfsg.1-5_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Signed by Ana Guerrero

iD8DBQFGzkz9n3j4POjENGERApVmAJ9azfIqs2OZUJbFohFLX1IiHO01cACeLl1R
XBLaDHWHsg0tHCYU9Mj8hMg=
=rKEJ
-----END PGP SIGNATURE-----


--- End Message ---

Reply to: