[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#292078: marked as done (kdebase: startkde does not check lnusertemp's result?)



Your message dated Sun, 20 May 2007 21:32:13 +0000
with message-id <E1Hpt0f-0007dc-Uu@ries.debian.org>
and subject line Bug#292078: fixed in kdebase 4:3.5.7-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: ksmserver
Version: 4:3.3.2-1
Priority: normal
Tags: security

The default startkde script provided with KDE does not seem to check any 
exit values for lnusertemp:

    165 # Link "tmp" resource to directory in /tmp
    166 # Creates a directory /tmp/kde-$USER and links $KDEHOME/tmp-$HOSTNAME to    166  it.
    167 lnusertemp tmp >/dev/null
    168
    169 # Link "socket" resource to directory in /tmp
    170 # Creates a directory /tmp/ksocket-$USER and links $KDEHOME/socket-$HOST    170 NAME to it.
    171 lnusertemp socket >/dev/null
    172
    173 # Link "cache" resource to directory in /var/tmp
    174 # Creates a directory /var/tmp/kdecache-$USER and links $KDEHOME/cache-$    174 HOSTNAME to it.
    175 lnusertemp cache >/dev/null

There are several reasons this is not correct, the most important being 
that if /tmp (or /var/tmp) are full and lnusertemp cannot do it's job 
(create a directory there), the startkde will happily keep on working even 
though the needed symlinks are not going to be there. 

IMHO the exit status of all of these actions should be tested, how about 
the attached patch to improve over the existing script? (it also includes a 
useful comment on how to prevent user files from ending up in /tmp or 
/var/tmp since KDE does not honor $TMPDIR)

Regards

Javier
--- startkde.orig	2005-01-25 00:48:59.000000000 +0100
+++ startkde	2005-01-25 00:51:18.000000000 +0100
@@ -162,20 +162,23 @@
     export GS_LIB
 fi
 
-# Link "tmp" resource to directory in /tmp
-# Creates a directory /tmp/kde-$USER and links $KDEHOME/tmp-$HOSTNAME to it.
-lnusertemp tmp >/dev/null
-
-# Link "socket" resource to directory in /tmp
-# Creates a directory /tmp/ksocket-$USER and links $KDEHOME/socket-$HOSTNAME to it.
-lnusertemp socket >/dev/null
-
-# Link "cache" resource to directory in /var/tmp
-# Creates a directory /var/tmp/kdecache-$USER and links $KDEHOME/cache-$HOSTNAME to it.
-lnusertemp cache >/dev/null
-
-# In case of dcop sockets left by a previous session, cleanup
-dcopserver_shutdown
+# Link "tmp" "socket" and "cache" resources to directory in /tmp
+# Creates:
+# - a directory /tmp/kde-$USER and links $KDEHOME/tmp-$HOSTNAME to it.
+# - a directory /tmp/ksocket-$USER and links $KDEHOME/socket-$HOSTNAME to it.
+# - a directory /var/tmp/kdecache-$USER and links $KDEHOME/cache-$HOSTNAME to it.
+# Note: temporary locations can be overriden through the KDETMP and KDEVARTMP
+# environment variables
+if [ ! -x "`which lnusertemp`" ] ; then
+	echo "Cannot find or run lnusertemp, aborting" >&2
+	exit 1
+fi
+for resource in tmp cache socket; do
+	if ! lnusertemp $resource >/dev/null; then
+		echo "Call to lnusertemp didn't succeed (temporary directories full?), aborting" >&2
+		exit 1
+	fi
+done
 
 echo 'startkde: Starting up...'  1>&2
 

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: kdebase
Source-Version: 4:3.5.7-1

We believe that the bug you reported is fixed in the latest version of
kdebase, which is due to be installed in the Debian FTP archive:

kappfinder_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kappfinder_3.5.7-1_i386.deb
kate_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kate_3.5.7-1_i386.deb
kcontrol_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kcontrol_3.5.7-1_i386.deb
kdebase-bin_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdebase-bin_3.5.7-1_i386.deb
kdebase-data_3.5.7-1_all.deb
  to pool/main/k/kdebase/kdebase-data_3.5.7-1_all.deb
kdebase-dbg_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdebase-dbg_3.5.7-1_i386.deb
kdebase-dev_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdebase-dev_3.5.7-1_i386.deb
kdebase-doc-html_3.5.7-1_all.deb
  to pool/main/k/kdebase/kdebase-doc-html_3.5.7-1_all.deb
kdebase-doc_3.5.7-1_all.deb
  to pool/main/k/kdebase/kdebase-doc_3.5.7-1_all.deb
kdebase-kio-plugins_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdebase-kio-plugins_3.5.7-1_i386.deb
kdebase_3.5.7-1.diff.gz
  to pool/main/k/kdebase/kdebase_3.5.7-1.diff.gz
kdebase_3.5.7-1.dsc
  to pool/main/k/kdebase/kdebase_3.5.7-1.dsc
kdebase_3.5.7-1_all.deb
  to pool/main/k/kdebase/kdebase_3.5.7-1_all.deb
kdebase_3.5.7.orig.tar.gz
  to pool/main/k/kdebase/kdebase_3.5.7.orig.tar.gz
kdepasswd_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdepasswd_3.5.7-1_i386.deb
kdeprint_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdeprint_3.5.7-1_i386.deb
kdesktop_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdesktop_3.5.7-1_i386.deb
kdm_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kdm_3.5.7-1_i386.deb
kfind_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kfind_3.5.7-1_i386.deb
khelpcenter_3.5.7-1_i386.deb
  to pool/main/k/kdebase/khelpcenter_3.5.7-1_i386.deb
kicker_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kicker_3.5.7-1_i386.deb
klipper_3.5.7-1_i386.deb
  to pool/main/k/kdebase/klipper_3.5.7-1_i386.deb
kmenuedit_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kmenuedit_3.5.7-1_i386.deb
konqueror-nsplugins_3.5.7-1_i386.deb
  to pool/main/k/kdebase/konqueror-nsplugins_3.5.7-1_i386.deb
konqueror_3.5.7-1_i386.deb
  to pool/main/k/kdebase/konqueror_3.5.7-1_i386.deb
konsole_3.5.7-1_i386.deb
  to pool/main/k/kdebase/konsole_3.5.7-1_i386.deb
kpager_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kpager_3.5.7-1_i386.deb
kpersonalizer_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kpersonalizer_3.5.7-1_i386.deb
ksmserver_3.5.7-1_i386.deb
  to pool/main/k/kdebase/ksmserver_3.5.7-1_i386.deb
ksplash_3.5.7-1_i386.deb
  to pool/main/k/kdebase/ksplash_3.5.7-1_i386.deb
ksysguard_3.5.7-1_i386.deb
  to pool/main/k/kdebase/ksysguard_3.5.7-1_i386.deb
ksysguardd_3.5.7-1_i386.deb
  to pool/main/k/kdebase/ksysguardd_3.5.7-1_i386.deb
ktip_3.5.7-1_i386.deb
  to pool/main/k/kdebase/ktip_3.5.7-1_i386.deb
kwin_3.5.7-1_i386.deb
  to pool/main/k/kdebase/kwin_3.5.7-1_i386.deb
libkonq4-dev_3.5.7-1_i386.deb
  to pool/main/k/kdebase/libkonq4-dev_3.5.7-1_i386.deb
libkonq4_3.5.7-1_i386.deb
  to pool/main/k/kdebase/libkonq4_3.5.7-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 292078@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org> (supplier of updated kdebase package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 15 May 2007 17:03:48 +0100
Source: kdebase
Binary: kdesktop kcontrol kpersonalizer kdm kdebase-doc-html kdebase-dbg klipper kappfinder kdebase-doc kdebase kmenuedit kicker libkonq4 konqueror-nsplugins kdebase-bin kdebase-dev ksplash kdeprint libkonq4-dev kwin kdepasswd ksmserver kfind kdebase-kio-plugins kpager khelpcenter kate ksysguard konqueror ktip ksysguardd kdebase-data konsole
Architecture: source i386 all
Version: 4:3.5.7-1
Distribution: unstable
Urgency: low
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Description: 
 kappfinder - non-KDE application finder for KDE
 kate       - advanced text editor for KDE
 kcontrol   - control center for KDE
 kdebase    - base components from the official KDE release
 kdebase-bin - core binaries for the KDE base module
 kdebase-data - shared data files for the KDE base module
 kdebase-dbg - debugging symbols for kdebase
 kdebase-dev - development files for the KDE base module
 kdebase-doc - developer documentation for the KDE base module
 kdebase-doc-html - KDE base documentation in HTML format
 kdebase-kio-plugins - core I/O slaves for KDE
 kdepasswd  - password changer for KDE
 kdeprint   - print system for KDE
 kdesktop   - miscellaneous binaries and files for the KDE desktop
 kdm        - X display manager for KDE
 kfind      - file-find utility for KDE
 khelpcenter - help center for KDE
 kicker     - desktop panel for KDE
 klipper    - clipboard utility for KDE
 kmenuedit  - menu editor for KDE
 konqueror  - KDE's advanced file manager, web browser and document viewer
 konqueror-nsplugins - Netscape plugin support for Konqueror
 konsole    - X terminal emulator for KDE
 kpager     - desktop pager for KDE
 kpersonalizer - installation personalizer for KDE
 ksmserver  - session manager for KDE
 ksplash    - the KDE splash screen
 ksysguard  - system guard for KDE
 ksysguardd - system guard daemon for KDE
 ktip       - useful tips for KDE
 kwin       - the KDE window manager
 libkonq4   - core libraries for Konqueror
 libkonq4-dev - development files for Konqueror's core libraries
Closes: 292078 362653
Changes: 
 kdebase (4:3.5.7-1) unstable; urgency=low
 .
   * New upstream release:
     - Now checks lnusertmp return values. (Closes: #292078)
     - Uses correct encoding in error messages. (Closes: #362653)
 .
   ++ Changes by Sune Vuorela:
 .
   * Patches:
     - Redo patch 18 about fonts.
     - Remove patch 21 - applied upstream.
     - Adapt patch 27 - kfreebsd - minor changes.
     - Adapt patch 41 - amd64 and nspluginviewer -  small changes.
     - Remove patch 42 - kwin and 64 bit. applied upstream.
     - Remove patch 44 - opengl logo is fixed.
     - Remove patch 45 - keyboard handler - applied upstream.
 .
   ++ Changes by Ana Beatriz Guerrero Lopez:
 .
   * Update kdebase-data.install to remove "Serbia and Montenegro" (yu), and
     add "Serbia" (rs) and "Montenegro" (me).
Files: 
 b96810b8aa26647164e055b5e21e972f 2063 kde optional kdebase_3.5.7-1.dsc
 de688e665828309c7f37fbb8277d5a4b 29211014 kde optional kdebase_3.5.7.orig.tar.gz
 1108099859d890458786217f11013c98 1085425 kde optional kdebase_3.5.7-1.diff.gz
 414fb2cfcf1b696cfbc794b47c3dd386 42722 kde optional kdebase_3.5.7-1_all.deb
 de8d15cffff85a7c1e1b5416314bf5f6 9808902 kde optional kdebase-data_3.5.7-1_all.deb
 616a33c9615388b356385738ba286ed6 1917488 doc optional kdebase-doc_3.5.7-1_all.deb
 1672550bf6794c50283d70732994e1e6 394156 doc optional kdebase-doc-html_3.5.7-1_all.deb
 2f338113098147bb9be7607cbc1a8bd3 299894 kde optional kappfinder_3.5.7-1_i386.deb
 436597190f1d459266842891d2a466b1 800130 editors optional kate_3.5.7-1_i386.deb
 8ed5db41a695f31ebf7d64894fcf6739 2985668 kde optional kcontrol_3.5.7-1_i386.deb
 a8a04b9e7e627619fff4ee6736a7d142 1298094 kde optional kdebase-bin_3.5.7-1_i386.deb
 827997e9512442dcf02b3fc9d4767910 82636 devel optional kdebase-dev_3.5.7-1_i386.deb
 394b80f2b3fd411752b23dee1bb62376 1128488 kde optional kdebase-kio-plugins_3.5.7-1_i386.deb
 b19db292a12170cb25efe0f7166cd040 246034 utils optional kdepasswd_3.5.7-1_i386.deb
 65704d10c71f4112e10c51a802d277f5 1478264 utils optional kdeprint_3.5.7-1_i386.deb
 a5ce392b658a4e3cfb0fa25faf47094d 786808 kde optional kdesktop_3.5.7-1_i386.deb
 15c819e0262cced64f69ad0784814314 641492 kde optional kdm_3.5.7-1_i386.deb
 cb4812d499ab5e60d42b2525dfd7538c 207470 utils optional kfind_3.5.7-1_i386.deb
 825b266df47021439635a7c8f8aec74b 2313422 kde optional khelpcenter_3.5.7-1_i386.deb
 2e5b018123eb86a7878607e6de7eda94 2076428 kde optional kicker_3.5.7-1_i386.deb
 89ffb950b3db7459e1de372f30dbcd99 279376 kde optional klipper_3.5.7-1_i386.deb
 5011b82c281f02fe8098b834064b21d1 386740 kde optional kmenuedit_3.5.7-1_i386.deb
 d149e81e54774875705247a4149eeedd 2043984 web optional konqueror_3.5.7-1_i386.deb
 690dfbde8a85fd5d7e331d912bb5c162 150100 utils optional konqueror-nsplugins_3.5.7-1_i386.deb
 d69fc7a5522b00ad4353496d775d83ac 745756 kde optional konsole_3.5.7-1_i386.deb
 e9b7532f18131d22627868f017fd0953 119710 kde optional kpager_3.5.7-1_i386.deb
 59f3a15789ae7625c258f33471356120 492718 kde optional kpersonalizer_3.5.7-1_i386.deb
 f4f7d4b52cdf218137ef74d2e4346e70 168366 kde optional ksmserver_3.5.7-1_i386.deb
 04005327ce981513f20c4750e3116043 716866 kde optional ksplash_3.5.7-1_i386.deb
 2d0aa3243503ba521b992a687a80a17a 509014 utils optional ksysguard_3.5.7-1_i386.deb
 02f10f3c33cd371daa68fbbcbb15f9c7 70966 utils optional ksysguardd_3.5.7-1_i386.deb
 27a5452374eb7473e741d034f274a861 107038 kde optional ktip_3.5.7-1_i386.deb
 00bd4d201bcf52fb4a06eeacad1b98c1 1045442 kde optional kwin_3.5.7-1_i386.deb
 13a780e3594f8cd00d5f6f240cd33f7f 276084 libs optional libkonq4_3.5.7-1_i386.deb
 874b971bc3edbef24e91b18104b427a1 66996 libdevel optional libkonq4-dev_3.5.7-1_i386.deb
 cde46dbc1fc77d3c4044bc5bac7d5181 32946240 libdevel extra kdebase-dbg_3.5.7-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Signed by Ana Guerrero

iD8DBQFGSgGRn3j4POjENGERAiwaAJ4rbz8/Fpo9fAuvZhbJrVwkZLOE4ACbBs3L
c4BnZosuxaIlPX5h8yWsJ2g=
=xLcV
-----END PGP SIGNATURE-----


--- End Message ---

Reply to: