[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#421005: marked as done (Causes FTBFS with GCC 4.3: error: extra ';')

Your message dated Fri, 11 May 2007 16:28:07 +0200
with message-id <20070511142807.GA30174@deprecation.cyrius.com>
and subject line Not a package bug, but one in the experimental compiler
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: kdepim
Version: 4:3.5.6.dfsg.1-2
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.

You can reproduce this problem with gcc-snapshot (20070422-1 or higher)
from unstable. (Currently not available for i386, but for amd64, powerpc
and ia64.  I hope to have i386 binaries in the archive in the near
future.)

> Automatic build of syncekonnector_0.3.2-3 on coconut0 by sbuild/ia64 0.49
...
> /usr/include/kde/libkcal/incidencebase.h:198: error: extra ';'
> /usr/include/kde/libkcal/incidencebase.h:202: error: extra ';'
> /usr/include/kde/libkcal/incidencebase.h: In member function 'int KCal::IncidenceBase::attendeeCount() const':
> /usr/include/kde/libkcal/incidencebase.h:202: warning: conversion to 'int' from 'size_t' may alter its value
> In file included from ../libksynce/eventsyncee.h:28,
>                  from eventhandler.h:32,
>                  from eventhandler.cpp:25:
> /usr/include/kde/libkcal/calendar.h: At global scope:
> /usr/include/kde/libkcal/calendar.h:805: error: extra ';'
> In file included from eventhandler.h:33,
>                  from eventhandler.cpp:25:
> ../includes/libkdepim/progressmanager.h:134: error: extra ';'
> ../includes/libkdepim/progressmanager.h:260: error: extra ';'

I doubt the following patch is complete (*) but I thought I'd submit it
anyway since you have CVS access.  Let's apply it and then we can
check later what's still broken.  (*) I cannot compile kdepim with gcc
4.3 right now because the compiler segfaults; there's a patch for this
problem already.

--- libkdepim/progressmanager.h~	2007-04-25 17:46:55.000000000 +0000
+++ libkdepim/progressmanager.h	2007-04-25 17:47:07.000000000 +0000
@@ -133,7 +133,7 @@
     /**
      * Recalculate progress according to total/completed items and update.
      */
-    void updateProgress() { setProgress( mTotal? mCompleted*100/mTotal: 0 ); };
+    void updateProgress() { setProgress( mTotal? mCompleted*100/mTotal: 0 ); }
 
     void addChild( ProgressItem *kiddo );
     void removeChild( ProgressItem *kiddo );
@@ -259,7 +259,7 @@
      * number as the id string for your progressItem to ensure it is unique.
      * @return
      */
-    static QString getUniqueID() { return QString::number( ++uID ); };
+    static QString getUniqueID() { return QString::number( ++uID ); }
 
      /**
       * Creates a ProgressItem with a unique id and the given label.
--- libkcal/incidencebase.h~	2007-04-25 17:46:19.000000000 +0000
+++ libkcal/incidencebase.h	2007-04-25 17:46:49.000000000 +0000
@@ -195,11 +195,11 @@
     /**
       Return list of attendees.
     */
-    const Attendee::List &attendees() const { return mAttendees; };
+    const Attendee::List &attendees() const { return mAttendees; }
     /**
       Return number of attendees.
     */
-    int attendeeCount() const { return mAttendees.count(); };
+    int attendeeCount() const { return mAttendees.count(); }
     /**
       Return the Attendee with this email address.
     */
--- libkcal/calendar.h~	2007-04-25 17:47:51.000000000 +0000
+++ libkcal/calendar.h	2007-04-25 17:48:07.000000000 +0000
@@ -802,7 +802,7 @@
            is being observed.
         */
         virtual void calendarModified( bool /*modified*/,
-                                       Calendar * /*calendar*/ ) {};
+                                       Calendar * /*calendar*/ ) {}
 
         /**
            Notify the Observer that an Incidence has been inserted.
--- libkcal/scheduler.h~	2007-04-25 17:48:08.000000000 +0000
+++ libkcal/scheduler.h	2007-04-25 17:48:22.000000000 +0000
@@ -55,7 +55,7 @@
       and a status.
     */
     ScheduleMessage( IncidenceBase *, int method, Status status );
-    ~ScheduleMessage() {};
+    ~ScheduleMessage() {}
     
     /**
       Return event associated with this message.
--- libkcal/calendarnull.h~	2007-04-25 17:48:23.000000000 +0000
+++ libkcal/calendarnull.h	2007-04-25 17:48:29.000000000 +0000
@@ -295,7 +295,7 @@
     */
     void incidenceUpdated( IncidenceBase * /*incidenceBase*/ ) {}
 
-    void setTimeZoneIdViewOnly( const QString& ) {};
+    void setTimeZoneIdViewOnly( const QString& ) {}
     
   private:
     static CalendarNull *mSelf;


-- 
Martin Michlmayr
http://www.cyrius.com/

--- End Message ---
--- Begin Message --- 
Ben Hutchings pointed out to me that this is in fact not a bug in your
code but in the compiler.  GCC shouldn't reject this code because it's
valid.  According to Ben, "A redundant semi-colon after a member function
definition in the class declaration is allowed.  In 9.2 [class.mem] the
grammar has "member-declaration: ... function-definition ;opt".

The good news is that this has been fixed in GCC in SVN, so it won't
be an issue with the next upload of the gcc-package anymore.  I'm
closing this bug report since it's not a bug.  Apologies for wasting
your time.

-- 
Martin Michlmayr
http://www.cyrius.com/

--- End Message ---
Reply to: