Bug#334889: kopete crashes when i send messages to icq contacts

[Josh Metzler <joshdeb@metzlers.org>]

tags 334889 +patch
thanks

On Thursday 20 October 2005 10:54 am, Juergen Richtsfeld wrote:
> Package: kopete
> Version: 4:3.4.2-3
> Severity: important
>
> this is what i get in the stdout/err
>
> lots of
> QDateTime::fromString: Parameter out of range
>
> and then:
> QMetaObject::findSignal:ClientStream: Conflict with Stream::readyRead()
> QMetaObject::findSignal:ClientStream: Conflict with Stream::readyRead()
> QObject::connect: No such signal TypingNotifyTask::gotInfo(const
> QString&) QObject::connect:  (sender name:   'unnamed')
> QObject::connect:  (receiver name: 'oscarclient')
> KCrash: Application 'kopete' crashing...

Great - it looks like a copy and paste error.  I haven't tested it, but
I think this patch should fix it:

--- kdenetwork-3.4.2/kopete/protocols/oscar/liboscar/client.cpp
+++ kdenetwork-3.4.2/kopete/protocols/oscar/liboscar/client.cpp
@@ -516,7 +516,7 @@
                 this, SIGNAL( receivedAwayMessage( const QString&, const QString& ) ) );
        connect( d->typingNotifyTask, SIGNAL( typingStarted( const QString& ) ),
                 this, SIGNAL( userStartedTyping( const QString& ) ) );
-       connect( d->typingNotifyTask, SIGNAL( gotInfo( const QString& ) ),
+       connect( d->typingNotifyTask, SIGNAL( typingFinished( const QString& ) ),
                 this, SIGNAL( userStoppedTyping( const QString& ) ) );
 }

(Attached too in case kmail wraps the lines).

Josh

--- kdenetwork-3.4.2/kopete/protocols/oscar/liboscar/client.cpp
+++ kdenetwork-3.4.2/kopete/protocols/oscar/liboscar/client.cpp
@@ -516,7 +516,7 @@
 	         this, SIGNAL( receivedAwayMessage( const QString&, const QString& ) ) );
 	connect( d->typingNotifyTask, SIGNAL( typingStarted( const QString& ) ),
 	         this, SIGNAL( userStartedTyping( const QString& ) ) );
-	connect( d->typingNotifyTask, SIGNAL( gotInfo( const QString& ) ),
+	connect( d->typingNotifyTask, SIGNAL( typingFinished( const QString& ) ),
 	         this, SIGNAL( userStoppedTyping( const QString& ) ) );
 }