[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#263895: segfaults if viewing source of a certain message



package kmail
forwarded 263895 http://bugs.kde.org/85175 
severity 263895 serious
tag 263895 patch
quit

* Marc Haber [Fri, 06 Aug 2004 09:14:42 +0200]:

> When I hit "V" to view the source of an HTML message, kmail segfaults.

  this seem to be happening to many other people, see [1]. I think this
  bug should get severity "serious" under the "in the package
  maintainer's opinion, makes the package unsuitable for release"
  statement. Chris, you agree with that?

    [1] http://lists.debian.org/debian-kde/2004/08/msg00059.html

  also, I'm attaching a mail that seems to reproduce the problem (from
  the KDE BTS entry).

  attached a patch also. it's the following diff:

    http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdepim/kmail/kmcommands.cpp.diff?r1=1.155&r2=1.156&f=h

  I'm asking for its backport to 3_2_BRANCH, anyway sarge *must* include
  it.

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
You've come to the right place.  At debian-devel we are always willing
to argue over the meanings of words.
                -- seen on debian-devel@l.d.o
From beirne@yahoo.com Fri Jul  9 14:40:53 2004
Return-path: <beirne@yahoo.com>
Envelope-to: beirne@localhost
Delivery-date: Fri, 09 Jul 2004 15:13:32 -0400
Received: from firenze ([127.0.0.1] helo=localhost)
	by firenze with esmtp (Exim 3.36 #1 (Debian))
	id 1Bj0oN-0003hu-02
	for <beirne@localhost>; Fri, 09 Jul 2004 15:13:31 -0400
Received: from pop-server.neo.rr.com [65.24.7.43]
	by localhost with POP3 (fetchmail-6.2.5)
	for beirne@localhost (single-drop); Fri, 09 Jul 2004 15:13:31 -0400 (EDT)
Received: from ms-mta-01 (ms-mta-01 [10.24.14.215])
 by ms-mss-01.columbus.rr.com
 (iPlanet Messaging Server 5.2 HotFix 1.21 (built Sep  8 2003))
 with ESMTP id <0I0L00CD3LMJFM@ms-mss-01.columbus.rr.com> for
 beirne@neo.rr.com; Fri, 09 Jul 2004 14:54:21 -0400 (EDT)
Received: from ohmx01.mgw.rr.com (ohmx01.mgw.rr.com [65.24.0.111])
 by ms-mta-01.columbus.rr.com
 (iPlanet Messaging Server 5.2 HotFix 1.21 (built Sep  8 2003))
 with ESMTP id <0I0L00746LAKU5@ms-mta-01.columbus.rr.com> for beirne@neo.rr.com
 (ORCPT beirne@neo.rr.com); Fri, 09 Jul 2004 14:42:20 -0400 (EDT)
Received: from web52603.mail.yahoo.com
 (web52603.mail.yahoo.com [206.190.39.141])
	by ohmx01.mgw.rr.com (8.12.10/8.12.8) with SMTP id i69If3F5013223	for
 <beirne@neo.rr.com>; Fri, 09 Jul 2004 14:41:33 -0400 (EDT)
Received: from [24.166.55.8] by web52603.mail.yahoo.com via HTTP; Fri,
 09 Jul 2004 11:40:53 -0700 (PDT)
Date: Fri, 09 Jul 2004 11:40:53 -0700 (PDT)
From: Beirne Konarski <beirne@yahoo.com>
Subject: 2nd message from yahoo
To: beirne@neo.rr.com
Message-id: <20040709184053.67546.qmail@web52603.mail.yahoo.com>
MIME-version: 1.0
Content-type: text/plain;
  charset=us-ascii
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Original-recipient: rfc822;beirne@neo.rr.com
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on firenze
X-Spam-Level: 
X-Spam-Status: No, hits=-1.4 required=5.0 tests=BAYES_01,RCVD_IN_SORBS 
	autolearn=no version=2.63
Status: R
X-Status: N
X-KMail-EncryptionState:  
X-KMail-SignatureState:  
X-KMail-MDN-Sent:  

 
 

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 


--- kmcommands.cpp	2004-08-08 15:10:45.000000000 +0200
+++ kmcommands.cpp.new	2004-08-08 15:12:08.000000000 +0200
@@ -552,9 +552,7 @@
 void KMShowMsgSrcCommand::execute()
 {
   KMMessage *msg = retrievedMessage();
-  QString str = QTextCodec::codecForName(  msg->charset().isEmpty() ?
-                QCString( kmkernel->networkCodec()->mimeName() ) :
-                msg->charset() )->toUnicode( msg->asString() );
+  QString str = msg->codec()->toUnicode( msg->asString() );
 
   MailSourceViewer *viewer = new MailSourceViewer(); // deletes itself upon close
   viewer->setCaption( i18n("Message as Plain Text") );

Reply to: