[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#227538: kdelibs: mixed results on 3.2.2



package kdelibs
tags 227538 +patch
thanks

Chris Cheney writes:

> On Tue, May 04, 2004 at 04:19:00PM -0700, Itai Seggev wrote:
>> The problem bug is a real bug and not a result of upgrading. I a
>> fresh install with the new sarge installer beta 4, and the problem
>> persisted. I also have discovered why this problem manifested in
>> 3.1.4-3. The binary packages search /etc/qt3/ and /usr/share/config
>> for config files. Up to (and including) 3.1.4-2, /usr/share/config
>> was a symlink to /etc/kde3; hence, it could find the config
>> files. In 3.1.4-3, this symlink was removed. This also explains why
>> installing from debian source over the binary package also fixed
>> the problem permanently: the source install installed the config
>> files into /usr/share/config, so any later binary package could
>> find the config files. Thus, there are 3 solutions to this (and
>> presumably other, related) bugs:

> Domi could you look into this a bit more? I can reproduce the
> problem now that I used the symlink, which indicates that
> kthemestyle isn't using the proper config file lookup mechanism, but
> I am not sure how it does the config file lookup. It sounds like it
> is hardcoding paths in its lookup instead of using the kde wide
> functions that are meant to be used! 8( The problem is probably in
> kthemebase.cpp somewhere.

> kdelibs/kstyles/kthemestyle/kthemebase.cpp
> kdelibs/kstyles/utils/installtheme/main.cpp

Chris, it's all your fault ;p

Ok to commit ?

cheers
domi

Index: debian/patches/10_kstandarddirs.diff
===================================================================
--- debian/patches/10_kstandarddirs.diff	(revision 125)
+++ debian/patches/10_kstandarddirs.diff	(working copy)
@@ -6,7 +6,7 @@
                          candidates->append(path);
                  }
 +                // UGLY HACK - Chris Cheney
-+                if (local && ("config" == type))
++                if (local && (!strcmp("config", type)))
 +                   candidates->append("/etc/kde3/");
 +                //
                  local = false;

Reply to: