[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#245820: [PATCH] Make KMilo compile on ppc



Hi,

As I'm not sure who's maintaining kmilo, I'm sending this to some
people holding copyright in the relevant files, and core-devel.

The attached patch is supposed to fix a compile failure [1] in
kdeutils/kmilo/powerbook2, which is caused by the pbbuttons library
having renamed the macro TAG_BRIGHTNESS to TAG_LCDBRIGHTNESS ( as
documented in the changelog [2] ).

Ok to commit this patch to BRANCH and HEAD ?

cheers
domi

Footnotes: 
[1]  http://buildd.debian.org/fetch.php?&pkg=kdeutils&ver=4%3A3.2.2-1&arch=powerpc&stamp=1082850620&file=log&as=raw

[2]  http://www.cymes.de/members/joker/projects/pbbuttons/clog-gtkpbbuttons.txt

Index: kmilo/powerbook2/pb_monitor.cpp
===================================================================
RCS file: /home/kde/kdeutils/kmilo/powerbook2/pb_monitor.cpp,v
retrieving revision 1.4.2.2
diff -u -r1.4.2.2 pb_monitor.cpp
--- kmilo/powerbook2/pb_monitor.cpp	27 Mar 2004 17:49:46 -0000	1.4.2.2
+++ kmilo/powerbook2/pb_monitor.cpp	25 Apr 2004 16:53:09 -0000
@@ -36,6 +36,12 @@
 //among which is "template"...
 #undef template
 #include <pbb.h>
+
+// TAG_BRIGHTNESS was renamed to TAG_LCDBRIGHTNESS in pbbuttons
+// 0.6.1-2
+#ifndef TAG_LCDBRIGHTNESS
+#define TAG_LCDBRIGHTNESS TAG_BRIGHTNESS
+#endif
 }
 
 #define BUFFERLEN	200
@@ -79,7 +85,7 @@
 			rc = Monitor::Mute;
 			m_progress = (int)tag->data;
 			break;
-		case TAG_BRIGHTNESS:
+		case TAG_LCDBRIGHTNESS:
 			rc = Monitor::Brightness;
 			m_progress = ((int)tag->data)*100/15;
 			break;

Reply to: