Bug#220310: marked as done (kaudiocreator: FTBFS - <linux/cdrom.h> is not usable from C++.)
Your message dated Tue, 9 Mar 2004 03:13:46 -0600
with message-id <20040309091346.GO19961@cheney.cx>
and subject line kdemultimedia_4:3.1.2-1(hppa/unstable): FTBFS: variable-size array forbdden by C++
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Nov 2003 23:25:48 +0000
>From pre@saruman.uio.no Tue Nov 11 17:25:30 2003
Return-path: <pre@saruman.uio.no>
Received: from pat.uio.no [129.240.130.16]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AJht4-0004u4-00; Tue, 11 Nov 2003 17:25:30 -0600
Received: from mail-mx3.uio.no ([129.240.10.44])
by pat.uio.no with esmtp (Exim 4.20)
id 1AJht3-0007Dr-C0
for submit@bugs.debian.org; Wed, 12 Nov 2003 00:25:29 +0100
Received: from saruman.uio.no ([129.240.201.202])
by mail-mx3.uio.no with esmtp (Exim 4.14)
id 1AJht2-0001uP-1h; Wed, 12 Nov 2003 00:25:28 +0100
Received: from pre by saruman.uio.no with local (Exim 2.12 #7)
id 1AJht1-0002ED-00; Wed, 12 Nov 2003 00:25:27 +0100
To: submit@bugs.debian.org
Subject: kaudiocreator: FTBFS - <linux/cdrom.h> is not usable from C++.
From: Petter Reinholdtsen <pere@hungry.com>
Message-Id: <E1AJht1-0002ED-00@saruman.uio.no>
Sender: Petter Reinholdtsen <petter.reinholdtsen@usit.uio.no>
Date: Wed, 12 Nov 2003 00:25:27 +0100
X-MailScanner-Information: This message has been scanned for viruses/spam. Contact postmaster@uio.no if you have questions about this scanning.
X-UiO-MailScanner: No virus found
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-7.9 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF
autolearn=ham version=2.53-bugs.debian.org_2003_11_9
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_11_9 (1.174.2.15-2003-03-30-exp)
Package: kdemultimedia
Version: 4:3.1.2-1.3
Severity: serious
TagS: patch
The latest upload fail to build on some archs (alpha, powerpc),
because the <linux/cdrom.h> include file fail to compile with the GNU
C++ compiler. This might be related to the use of -pedantic and
-ansi). This is reported as a bug against glibc, #203303, and that
problem should be fixed as well, I guess.
But the proper fix for this is probably to stop using the kernel
header file, and instead include a standalone header file with the
structs and defines needed by kdemultimedia. Here is a patch to
implement that.
--- kdemultimedia-3.1.2/kaudiocreator/cdconfigimp.cpp.orig Wed Nov 12 00:16:53 2003
+++ kdemultimedia-3.1.2/kaudiocreator/cdconfigimp.cpp Wed Nov 12 00:17:08 2003
@@ -75,7 +75,7 @@
{
/* This is in support for the Mega Hack, if cdparanoia ever is fixed, or we
use another ripping library we can remove this. */
-#include <linux/cdrom.h>
+#include <linux-cdrom.h>
#include <sys/ioctl.h>
}
--- /dev/null Thu Jan 1 01:00:00 1970
+++ kdemultimedia-3.1.2/kaudiocreator/linux-cdrom.h Wed Nov 12 00:12:29 2003
@@ -0,0 +1,49 @@
+/*
+ * -- <linux-cdrom.h>
+ * Based on info in <linux/cdrom.h> in the linux kernel.
+ */
+
+#ifndef _LINUX_CDROM_H
+#define _LINUX_CDROM_H
+
+typedef unsigned char __u8;
+
+/*******************************************************
+ * The CD-ROM IOCTL commands -- these should be supported by
+ * all the various cdrom drivers. For the CD-ROM ioctls, we
+ * will commandeer byte 0x53, or 'S'.
+ *******************************************************/
+#define CDROMMULTISESSION 0x5310 /* Obtain the start-of-last-session
+ address of multi session disks
+ (struct cdrom_multisession) */
+
+/* CD-ROM address types (cdrom_tocentry.cdte_format) */
+#define CDROM_LBA 0x01 /* "logical block": first frame is #0 */
+
+/* Address in MSF format */
+struct cdrom_msf0
+{
+ __u8 minute;
+ __u8 second;
+ __u8 frame;
+};
+
+/* Address in either MSF or logical format */
+union cdrom_addr
+{
+ struct cdrom_msf0 msf;
+ int lba;
+};
+
+/* This struct is used with the CDROMMULTISESSION ioctl */
+struct cdrom_multisession
+{
+ union cdrom_addr addr; /* frame address: start-of-last-session
+ (not the new "frame 16"!). Only valid
+ if the "xa_flag" is true. */
+ __u8 xa_flag; /* 1: "is XA disk" */
+ __u8 addr_format; /* CDROM_LBA or CDROM_MSF */
+};
+
+
+#endif /* _LINUX_CDROM_H */
---------------------------------------
Received: (at 220310-done) by bugs.debian.org; 9 Mar 2004 09:14:20 +0000
>From ccheney@cheney.cx Tue Mar 09 01:14:20 2004
Return-path: <ccheney@cheney.cx>
Received: from 66-194-152-191.gen.twtelecom.net (pico.surpasshosting.com) [66.194.152.191]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1B0dJc-0006co-00; Tue, 09 Mar 2004 01:14:20 -0800
Received: from conr-adsl-cheney.txucom.net ([207.70.165.48] helo=calc)
by pico.surpasshosting.com with esmtp (TLSv1:RC4-SHA:128)
(Exim 4.24)
id 1B0dJG-00046S-Bz; Tue, 09 Mar 2004 04:13:58 -0500
Received: from ccheney by calc with local (Exim 4.30)
id 1B0dJ4-00088F-6K; Tue, 09 Mar 2004 03:13:46 -0600
Date: Tue, 9 Mar 2004 03:13:46 -0600
From: Chris Cheney <ccheney@cheney.cx>
To: 203919-done@bugs.debian.org, 220174-done@bugs.debian.org,
220176-done@bugs.debian.org, 220179-done@bugs.debian.org,
220310-done@bugs.debian.org
Subject: kdemultimedia_4:3.1.2-1(hppa/unstable): FTBFS: variable-size array forbdden by C++
Message-ID: <20040309091346.GO19961@cheney.cx>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="Vy1A5eXR7jld12ZH"
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - pico.surpasshosting.com
X-AntiAbuse: Original Domain - bugs.debian.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - cheney.cx
Delivered-To: 220310-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_08
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=2.6 required=4.0 tests=SUSPICIOUS_RECIPS autolearn=no
version=2.60-bugs.debian.org_2004_03_08
X-Spam-Level: **
--Vy1A5eXR7jld12ZH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
These FTBFS bugs are fixed in both sarge/sid.
Chris
--Vy1A5eXR7jld12ZH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFATYrK0QZas444SvIRAomgAJ0QdH1njwLuxJB4CjlGKCqU6lVJXwCgmmcd
LypZ+vi5FDcA1811C6oyZ34=
=Dziq
-----END PGP SIGNATURE-----
--Vy1A5eXR7jld12ZH--
Reply to: