[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#702908: PTS: upload signature parsing patch



On 03/13/2013 08:29 AM, Raphael Hertzog wrote:
> On Wed, 13 Mar 2013, Paul Wise wrote:
>> Hmmm, not sure what to say there. It seems like a reasonable approach for now.
> 
> Yes.

Good.

>> I guess this is needed for the developer.php links, fair enough.
> 
> I don't understand your comment. Markus, it's certainly possible to update
> all news.xml once with a new structure.
> 
> $ bin/list_packages.sh | bin/update_news.py
> 
> So if you can simplify, please do it.

Okay, I'll drop the "from" attribute and support for it in XSLT
entirely, then.

> I noticed in particular that you used <xsl:when> a few times where a simple
> <xsl:if> would have been more appropriate.

Will check.

> I also saw a "print" that you
> probably left while debugging (print "signature uid: …).

Oops. Yeah, that shouldn't be there. Sorry.

Regards

Markus Wanner

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: