Bug#164410: qa.debian.org: developer.php opens excuses links in a new window/popup
Package: qa.debian.org
Version: unavailable; reported 2002-10-12
Severity: wishlist
Tags: patch
When looking at the excuses for a package from developer.php, the "out of
date" links cause the browser to open the link in a new window, thanks to
the target="_blank" attribute in the <a href>. I traced it to the actual
update_excuses.html, where it is useful to open a new window with the buildd
log in it because the page is so huge, but with developer.php, the excuses
page are per package and so navigating the pages within one window is
desirable.
I've attached a patch that simply cuts the target attribute out of the "out
of date" lines when extract.pl builds the excuses cache.
My perl's a little rusty, so there's probably some glaring bug in the patch,
but hopefully it's clear enough.
willow% cvs diff
Index: ddpo/DDPO.pm
===================================================================
RCS file: /cvs/qa/data/ddpo/DDPO.pm,v
retrieving revision 1.4
diff -u -r1.4 DDPO.pm
--- ddpo/DDPO.pm 6 Sep 2002 11:33:32 -0000 1.4
+++ ddpo/DDPO.pm 12 Oct 2002 02:51:25 -0000
@@ -160,6 +160,10 @@
$package =~ s/\\//g;
# print "$package $WWW $first_char $link\n";
print PACK_EXC "<li>Depends: $package <a href=\"${WWW}/developer.php?excuse=${link}\">$link<\/a>\n";
+ }elsif((m/^<li>out of date on/) && ($valid == 1)){
+ # make out-of-date links appear in the same window
+ s/ target="_blank"//g;
+ print PACK_EXC;
}elsif(($open == 1) && ($valid == 1)){
print PACK_EXC;
}
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux willow 2.4.18 #1 Wed Sep 11 14:08:50 EST 2002 i686
Locale: LANG=en_AU, LC_CTYPE=en_AU
--
jaq@debian.org http://people.debian.org/~jaq
Reply to: