[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#861443: ora2pg: please make the build reproducible



Control: tags -1 fixed-upstream

On Thu, 04 May 2017 17:35:00 +0000 Niels Thykier <niels@thykier.net> wrote:
> Control: tags -1 moreinfo
> 
> [...]
> 
> Hi Chris,
> 
> I suspect your patch is wrong because the original code is wrong as well.
> 
> $$ in postgres SQL is (often?) used to delimit the definition of
> triggers and functions.  Therefore, I think you rather want the $$ to be
> literal $$ in the config file rather than a ("random") number.
> 
> Thanks,
> ~Niels
> 
> 

Checked and it is fixed upstream in 18.1:

"""
  - Fix shell replacement of $$ in function definition in Makefile.PL
    embedded configuration file. Thanks to kuzmaka for the report.
"""

Thanks,
~Niels


Reply to: