Bug#832291: bogofilter-{bdb, sqlite, tokyocabinet}: copyright file missing after upgrade (policy 12.5)

[Herbert <terberh@gmail.com>]

Hi Andreas Beckmann,

I did the last upload. Please see below.


> a test with piuparts revealed that your package misses the copyright
> file after an upgrade, which is a violation of Policy 12.5:
> https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile
>
> After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.
>
> This was observed on the following upgrade paths:
>
> jessie -> stretch
>
> >From the attached log (scroll to the bottom...):
>
> 1m18.5s ERROR: WARN: Inadequate results from running adequate!
>   bogofilter-bdb: missing-copyright-file /usr/share/doc/bogofilter-bdb/copyright
>
>   MISSING COPYRIGHT FILE: /usr/share/doc/bogofilter-bdb/copyright
>   # ls -lad /usr/share/doc/bogofilter-bdb
>   drwxr-xr-x 2 root root 40 Jun 10 11:52 /usr/share/doc/bogofilter-bdb
>   # ls -la /usr/share/doc/bogofilter-bdb/
>   total 0
>   drwxr-xr-x   2 root root   40 Jun 10 11:52 .
>   drwxr-xr-x 109 root root 2300 Jun 10 11:52 ..
>
>
> Additional info may be available here:
> https://wiki.debian.org/MissingCopyrightFile
>
> Note that dpkg intentionally does not replace directories with symlinks
> and vice versa, you need the maintainer scripts to do this.
> See in particular the end of point 4 in
> https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase
>
> It is recommended to use the dpkg-maintscript-helper commands
> 'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
> to perform the conversion, ideally using d/$PACKAGE.maintscript.
> Do not forget to add 'Pre-Depends: ${misc:Pre-Depends}' in d/control.
> See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.

bogofilter-{bdb, sqlite, tokyocabinet} depends on bogofilter-common[0], 
which has the copyright file[1]. And I used:

debian/rules:

override_dh_installdocs:
	dh_installdocs --link-doc=bogofilter-common

[0] - 
https://anonscm.debian.org/git/collab-maint/bogofilter.git/tree/debian/control
[1] - https://packages.debian.org/sid/all/bogofilter-common/filelist


Debian Policy 12.5 says:

"/usr/share/doc/package may be a symbolic link to another directory in 
/usr/share/doc only if the two packages both come from the same source 
and the first package Depends on the second. These rules are important 
because copyright files must be extractable by mechanical means."

I will check the current dh_installdocs manpage tomorrow.



regards,
Herbert