Re: Comments regarding xen-api_1.3-14_amd64.changes
On 01/07/2012 08:44 PM, Luca Falavigna wrote:
> Hi,
>
> it seems python files in python-xenapi package aren't byte-compiled properly.
> You may want to refine dh_python2 call to fix that.
>
> Cheers,
> Luca
Hi Luca,
Good catch, thanks for noticing it and letting me know! I was doing
"dh_python2 /usr/lib/xcp", thinking that dh_python2 would only take that
folder as a supplementary one, but in fact, it seems that when I do
that, dh_python2 doesn't look anymore in /usr/lib/python*.
Frankly, I think this is an issue in the man page of dh_python2 which
doesn't explain how it works correctly. I've been staring at the man
page trying to guess what would happen, and here, miserably failed
(truth, I should have double checked the result, but still...).
Now, my understanding of the man page is that I should have done:
override_dh_python2:
dh_python2
dh_python2 --skip-private /usr/lib/xcp
Best would have been to explicitly write that one example in the man
page, IMHO (see patch attached). Please let me know if I'm wrong here.
I'm Cc:-ing debian-python@lists.debian.org and doko (current maintainer
for python) hoping that the man page can be fixed and such explicit
example added.
Cheers,
Thomas
P.S: There was other issues on this xen-api package that also pushed me
for another upload (like python-xenapi should have Replaces: xcp-xapi).
--- a/dh_python2.rst 2012-01-08 04:53:09.000000000 +0000
+++ b/dh_python2.rst 2012-01-08 04:55:33.000000000 +0000
@@ -70,6 +70,13 @@
dh_python2 with --skip-private option and add another call with a path to this
directory and new options.
+For example, if your package is called foo, and packages things in the folder
+/usr/lib/foo-bar, then you could do the following in your debian/rules:
+
+override_dh_python2:
+ dh_python2
+ dh_python2 --skip-private /usr/lib/foo-bar
+
pyinstall files
~~~~~~~~~~~~~~~
Files listed in debian/pkg.pyinstall file will be installed as public modules
Reply to: