--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: hplip-gui: traceback when launching hp-toolbox
- From: Julien Patriarca <leatherface@debian.org>
- Date: Mon, 30 Jan 2023 17:27:10 +0100
- Message-id: <167509603001.379644.11740875967159278497.reportbug@desktop.home.lan>
Package: hplip-gui
Version: 3.22.10+dfsg0-1
Severity: grave
Tags: patch
Justification: renders package unusable
Dear Maintainer,
* What led up to the situation?
Trying to launch hp-toolbox software, got this output:
Traceback (most recent call last):
File "/usr/bin/hp-toolbox", line 280, in <module>
toolbox = ui.DevMgr5(__version__, device_uri, None)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/ui5/devmgr5.py", line 238, in __init__
core = CoreInstall(MODE_CHECK)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/installer/core_install.py", line 240, in __init__
self.passwordObj = password.Password(ui_mode)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/base/password.py", line 94, in __init__
self.__readAuthType() # self.__authType
^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/hplip/base/password.py", line 119, in __readAuthType
distro_name = get_distro_std_name(os_name)
^^^^^^^^^^^^^^^^^^^
NameError: name 'get_distro_std_name' is not defined. Did you mean: 'get_distro_name'?
* What exactly did you do (or not do) that was effective (or
ineffective)?
I patched the password.py file with the correct function name and
delete the os_name parameter when being called.
* What was the outcome of this action?
Positive. The hp-toolbox launched succesfully.
-- Package-specific info:
Saving output in log file: /home/julien/hp-check.log
HP Linux Imaging and Printing System (ver. 3.22.10)
Dependency/Version Check Utility ver. 15.1
Copyright (c) 2001-18 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.
Note: hp-check can be run in three modes:
1. Compile-time check mode (-c or --compile): Use this mode before compiling the HPLIP supplied tarball (.tar.gz or .run) to determine if the proper dependencies are installed to successfully compile HPLIP.
2. Run-time check mode (-r or --run): Use this mode to determine if a distro supplied package (.deb, .rpm, etc) or an already built HPLIP supplied tarball has the proper dependencies installed to successfully run.
3. Both compile- and run-time check mode (-b or --both) (Default): This mode will check both of the above cases (both compile- and run-time dependencies).
-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (990, 'testing'), (10, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-1-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages hplip-gui depends on:
ii dbus-user-session [default-dbus-session-bus] 1.14.4-1
ii hplip 3.22.10+dfsg0-1
ii python3-dbus.mainloop.pyqt5 5.15.7+dfsg-3+b3
ii python3-pyqt5 5.15.7+dfsg-3+b3
Versions of packages hplip-gui recommends:
ii python3-notify2 0.3-5
ii simple-scan 42.5-2
hplip-gui suggests no packages.
-- no debconf information
--- password.py 2023-01-30 17:15:43.563960616 +0100
+++ /usr/share/hplip/base/password.py 2023-01-15 11:39:02.000000000 +0100
@@ -116,8 +116,7 @@
# added replace() to remove the spaces in distro_name
(os_name,_ver) = utils.get_distro_name() #.lower().replace(" ","")
os_name = os_name.lower().replace(" ","")
- #distro_name = get_distro_std_name(os_name)
- distro_name = get_distro_name()
+ distro_name = get_distro_std_name(os_name)
self.__authType = user_conf.get('authentication', 'su_sudo', '')
if self.__authType != "su" and self.__authType != "sudo":
try:
--- password.py 2023-01-30 17:15:43.563960616 +0100
+++ /usr/share/hplip/base/password.py 2023-01-15 11:39:02.000000000 +0100
@@ -116,8 +116,7 @@
# added replace() to remove the spaces in distro_name
(os_name,_ver) = utils.get_distro_name() #.lower().replace(" ","")
os_name = os_name.lower().replace(" ","")
- #distro_name = get_distro_std_name(os_name)
- distro_name = get_distro_name()
+ distro_name = get_distro_std_name(os_name)
self.__authType = user_conf.get('authentication', 'su_sudo', '')
if self.__authType != "su" and self.__authType != "sudo":
try:
--- password.py 2023-01-30 17:15:43.563960616 +0100
+++ /usr/share/hplip/base/password.py 2023-01-15 11:39:02.000000000 +0100
@@ -116,8 +116,7 @@
# added replace() to remove the spaces in distro_name
(os_name,_ver) = utils.get_distro_name() #.lower().replace(" ","")
os_name = os_name.lower().replace(" ","")
- #distro_name = get_distro_std_name(os_name)
- distro_name = get_distro_name()
+ distro_name = get_distro_std_name(os_name)
self.__authType = user_conf.get('authentication', 'su_sudo', '')
if self.__authType != "su" and self.__authType != "sudo":
try:
--- End Message ---
--- Begin Message ---
Source: hplip
Source-Version: 3.22.10+dfsg0-2
Done: Thorsten Alteholz <debian@alteholz.de>
We believe that the bug you reported is fixed in the latest version of
hplip, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1030043@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thorsten Alteholz <debian@alteholz.de> (supplier of updated hplip package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 05 Mar 2023 00:39:02 +0100
Source: hplip
Architecture: source
Version: 3.22.10+dfsg0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Printing Team <debian-printing@lists.debian.org>
Changed-By: Thorsten Alteholz <debian@alteholz.de>
Closes: 1010805 1029459 1030043 1031233 1031784
Changes:
hplip (3.22.10+dfsg0-2) unstable; urgency=medium
.
* rework patch that uses distro module (0075 at the moment)
Thanks to Mark Hindley and others for detecting and fixing this!
(Closes: #1010805, #1029459, #1030043, #1031233, #1031784)
Checksums-Sha1:
0618c3300b261349f99cd5018c3b29b720e123c2 3212 hplip_3.22.10+dfsg0-2.dsc
a4635985d537771df30743874f512f0f99636ce0 140124 hplip_3.22.10+dfsg0-2.debian.tar.xz
b605473ab64c4dd903957dab2bd08647d40da207 19566 hplip_3.22.10+dfsg0-2_amd64.buildinfo
Checksums-Sha256:
c9996b71ed9d94f646d2996d0f5027c05aca73051dc405b31aefe174d5c678d0 3212 hplip_3.22.10+dfsg0-2.dsc
562eb84c2c1082a9c23f38ecb563a1b1c3c7920941c7c3aad4dc12e73a708bb8 140124 hplip_3.22.10+dfsg0-2.debian.tar.xz
484fc8069c2980fc53181ac0ea7ab34ec53ce483c8f3b23256f235a257652c4e 19566 hplip_3.22.10+dfsg0-2_amd64.buildinfo
Files:
68ca94dbc1c242bd110d4ed260cd3489 3212 utils optional hplip_3.22.10+dfsg0-2.dsc
1797267b537b9bf3213b9a94522c2224 140124 utils optional hplip_3.22.10+dfsg0-2.debian.tar.xz
58367f45b9cca31ccc71ddb5ff79f137 19566 utils optional hplip_3.22.10+dfsg0-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKmBAEBCgCRFiEEYgH7/9u94Hgi6ruWlvysDTh7WEcFAmQD2l1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYy
MDFGQkZGREJCREUwNzgyMkVBQkI5Njk2RkNBQzBEMzg3QjU4NDcTHGRlYmlhbkBh
bHRlaG9sei5kZQAKCRCW/KwNOHtYRxkqD/dCK7fSzYaxp/KO+LKZv6MMAGR9dhQ4
cERU1l6YE+p7fFJpv2FmmqJBsMYmfnSike5rO5CBRi2mgVw2WZZDi7wbWePv4reD
AgB9eYLeEpgN/ulByqlLm/hz6nGQz8LSYYbXZbtT3nVBcnEcn++Ven3qvXhcCqfU
ODmo8cai6LaPfvsXPbBe4ESMkh9TW+GAlqsRowK2rbLHiwxhgJ8p+7uq1Yg7G9dM
EGVVaRIuUqNyGAOmLRk7SFokDQdUIZHKXHL8LnVFGImEKy/cEVXl4wJCRL1mc0Bv
NfzmA3mSjad/XaxgWxZushZDwMiJlPiTfO6c0ezsf4hm33MtkZo49jwXNApDui6c
aje30nTwGilooDuqcJjd8AMZRSLwycUUr27TY4l8EeSB7KfMHRafqOjy0Q5sujxM
whl7jq3IgY0Mrdh0c7r7Emub/hrsKB3QU7PNDOU3H5tfy6ew9WtKEg6M57r8TwrS
Q68KqLwlYWxjAEP74gguaeBwAkAx4XKKxzXIDIpXAgE6eJpY60suPF//+6QSwSZL
/YWKCZQLrRXy7qOc+XfwTVfJ6YiWaStT+dAywl5e6Jd0pjCYmLI37PhYiPPoLHns
eXIq5sZXHH25xo0/qVloM76Dz8IMYoNo08vAg7XcXbKWGu2tzUeYVR6QAsGjf5s4
dTT5UWJVCQk3
=ZTx6
-----END PGP SIGNATURE-----
--- End Message ---