[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#679117: printer-driver-ptouch: Incorrect Margins for PT9500PC and PT9800PCN



Thank you very much for the patch.

In your patch you write "Attention: Not tested on other printers." and indeed your patch changes code which affects all supported printers, not only the two models with which you were suffering the problem. This can easily break things on the other printers, assuming that most supported printers work correctly with the original code. If you are not sure that the change works for all printers you should do it in a way that it only applies if the printer is one of the models for which you have made the change.

   Till



Reply to: