Re: rivafb on 12" pbook
On Mon, 2 Feb 2004, Guido Guenther wrote:
> On Mon, Feb 02, 2004 at 05:35:18PM +0100, Guido Guenther wrote:
> > I'm having trouble getting 2.6.2-rc1-ben1 to work on my 12" pbook
> > (pciid: 0x0179). The problem is rivafb. There seem to be several issues:
> > - rivafb_imageblit doesn't draw into the "visible part" of the
> > framebuffer, it draws right "above" it (you can see the lowest line
> > of the software cursor moving on the first line of the screen).
> > This only happens for the "text" case where image->depth == 1, since
> > the penguin gets drawn fine.
> This is caused by the fact that my albook has actually a NV17 not a NV20
> as detected. So we should use the NV10 code paths. This patch against
> 2.6.2-rc2 fixes it, please apply:
>
> --- ../benh-rsync-2.6-clean/drivers/video/riva/fbdev.c 2003-12-24 08:30:11.000000000 +0100
> +++ drivers//video/riva/fbdev.c 2004-02-02 18:27:21.000000000 +0100
> @@ -181,7 +181,11 @@
> { "GeForce4-420-GO", NV_ARCH_20 },
> { "GeForce4-420-GO-M32", NV_ARCH_20 },
> { "Quadro4-500-XGL", NV_ARCH_20 },
> +#if defined(__powerpc__)
> + { "GeForce4-MX-Mac", NV_ARCH_10 },
> +#else
> { "GeForce4-440-GO-M64", NV_ARCH_20 },
> +#endif
> { "Quadro4-200", NV_ARCH_20 },
> { "Quadro4-550-XGL", NV_ARCH_20 },
> { "Quadro4-500-GOGL", NV_ARCH_20 },
>
> Thanks a lot to Mark Vojkovic for pointing this out.
>
> The machine still crashes when switching back from X to the console
> though. Does this also happen with other NV cards? Im Running XFree86
> 4.3.99.902.
> Cheers,
> -- Guido
Most of your architecture assignments are wrong. ALL of those
in the above snipped are NV_ARCH_10. You should use the logic in
the "nv" driver.
Mark.
Reply to: