[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please adopt arename



On Thu, 02 Feb 2012 21:02:48 +0100, Frank Terbeck wrote:

> Hey there, gregor,

Hi Frank!
 
> > Adopted, upgraded and uploaded now.
> Thanks for taking care of this package.

You're welcome!
 
> However, there's a problem with that. You're using github's
> auto-generated tarballs. Those are missing a "VERSION" file.

Oops, I hadn't realized this.

(I just took the "tag-tarball" because I had a problem with the
debian/watch file and tried to be clever instead of fixing it :/)
 
> The thing is, that during script-generation, the current version is
> deduced from the state of the git repository (nearest version tag, etc).
> Since that state is not a available in tarballs, I'm add that VERSION
> file when I'm generating those release tarballs.

Ok.
 
> The version information in the manpages will be broken. And the script
> will report "VERSION" instead of the actual version (ie "4.0").

That's indeed bad™.
 
> I am always uploading properly generated tarballs to
>   <https://github.com/ft/arename/downloads>

> Maybe you can still pull the current tarball out of incoming, because
> I've heard the process of replacing an .orig tarball is a pain, once it
> made it to the mirrors.

It's already ACCEPTED, so I can either upload 4.0 with a "fake"
version (like "4.0+released" or "4.0+VERSION"); or just add the
VERSION file as a patch for now.

(Speaking of patches: cf. attachment). 


I'll have a look now.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Joan Baez: Wozu sind Kriege da
Description: typo
Origin: vendor
Forwarded: no
Author: gregor herrmann <gregoa@debian.org>
Last-Update: 2012-02-02

--- a/arename.in
+++ b/arename.in
@@ -883,7 +883,7 @@
 
 =back
 
-Backslashes are special in template strings, becuase they are used to
+Backslashes are special in template strings, because they are used to
 quote characters that bear special meaning (for example, to get a
 ampersand character, you need to use "B<\&>"). To get an actual
 backslash in the resulting string, you need to use a backslash, quoted

Attachment: signature.asc
Description: Digital signature


Reply to: