Bug#993045: Please bring back the -unsafe-string switch
Le 06/09/2021 à 11:01, Julien Puydt a écrit :
> The configure script checks for the availability of the switch, and
> adds it to OCAMLCFLAGS... I checked String.set doesn't seem to be used
> and String.blit only once, so perhaps there's something simple to do.
>
> My current packaging is available here:
> https://salsa.debian.org/science-team/scilab
I've removed the check (patch attached), and the package builds with no
errors. I don't know how to check that everything works properly, though.
Cheers,
--
Stéphane
>From a2856e548fa6084c02d3b67205ca94c0b9177bf4 Mon Sep 17 00:00:00 2001
From: Stephane Glondu <steph@glondu.net>
Date: Tue, 7 Sep 2021 12:51:42 +0200
Subject: [PATCH] Remove check for ocaml's -unsafe-string
---
scilab/m4/ocaml.m4 | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/scilab/m4/ocaml.m4 b/scilab/m4/ocaml.m4
index f25e10a08..11323c8a6 100644
--- a/scilab/m4/ocaml.m4
+++ b/scilab/m4/ocaml.m4
@@ -23,22 +23,10 @@ AC_DEFUN([AC_CHECK_PROG_OCAML],[
if test "$OCAMLC" = no; then
AC_MSG_ERROR([ocamlc not found. Mandatory to build the Scicos modelica compiler (Use --without-modelica to disable the Modelica compiler).])
fi
- # since ocaml 4.06, unsafe string is no more the default parameter ; enforce it
- "$OCAMLC" -unsafe-string
- if test "$?" -ne "0"; then
- AC_MSG_WARN([ocamlc does not support "-unsafe-string". Needed to build the Scicos modelica compiler (Use --without-modelica to disable the Modelica compiler).])
- fi
- OCAMLCFLAGS="$OCAMLCFLAGS -unsafe-string"
AC_CHECK_PROG(OCAMLOPT,ocamlopt,ocamlopt,no)
if test "$OCAMLOPT" = no; then
AC_MSG_ERROR([ocamlopt not found. Mandatory to build the Scicos modelica compiler.])
fi
- # since ocaml 4.06, unsafe string is no more the default parameter ; enforce it
- "$OCAMLOPT" -unsafe-string
- if test "$?" -ne "0"; then
- AC_MSG_WARN([ocamlc does not support "-unsafe-string". Needed to build the Scicos modelica compiler (Use --without-modelica to disable the Modelica compiler).])
- fi
- OCAMLOPTFLAGS="$OCAMLOPTFLAGS -unsafe-string"
AC_CHECK_PROG(OCAMLDEP,ocamldep,ocamldep,no)
if test "$OCAMLDEP" = no; then
AC_MSG_ERROR([ocamldep not found. Mandatory to build the Scicos modelica compiler.])
--
2.33.0
Reply to: