[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1067494: marked as done (obs-studio: FTBFS on time64_t archs)

Your message dated Sun, 31 Mar 2024 13:39:07 +0000
with message-id <E1rqvOt-005S2n-TI@fasolo.debian.org>
and subject line Bug#1067494: fixed in obs-studio 30.0.2+dfsg-3
has caused the Debian Bug report #1067494,
regarding obs-studio: FTBFS on time64_t archs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1067494: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067494
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: obs-studio
Version: 30.0.2+dfsg-2.1
Severity: serious



Hello, looks like we got a failure due to time64_t transition.

/usr/bin/cc -DENABLE_HEVC -DHAVE_OBSCONFIG_H -DHAVE_UDEV -Dlinux_v4l2_EXPORTS -I/<<PKGBUILDDIR>>/libobs -I/<<PKGBUILDDIR>>/obj-arm-linux-gnueabihf/config -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/obs-studio-30.0.2+dfsg-2.1build2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=3 -DFFMPEG_MUX_FIXED=\"/usr/lib/arm-linux-gnueabihf/obs-plugins/obs-ffmpeg/obs-ffmpeg-mux\" -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -fvisibility=hidden -Wno-error=deprecated-declarations -std=gnu17 -fPIC -Werror -Wextra -Wvla -Wno-error=vla -Wswitch -Wno-error=switch -Wformat -Wformat-security -Wunused-parameter -Wno-unused-function -Wno-missing-field-initializers -fno-strict-aliasing -Werror-implicit-function-declaration -Wno-missing-braces -Wno-error=maybe-uninitialized -DSIMDE_ENABLE_OPENMP -fopenmp-simd -MD -MT plugins/linux-v4l2/CMakeFiles/linux-v4l2.dir/v4l2-input.c.o -MF plugins/linux-v4l2/CMakeFiles/linux-v4l2.dir/v4l2-input.c.o.d -o plugins/linux-v4l2/CMakeFiles/linux-v4l2.dir/v4l2-input.c.o -c /<<PKGBUILDDIR>>/plugins/linux-v4l2/v4l2-input.c
/<<PKGBUILDDIR>>/plugins/linux-v4l2/v4l2-input.c: In function ‘v4l2_thread’:
/<<PKGBUILDDIR>>/plugins/linux-v4l2/v4l2-input.c:66:43: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘__suseconds64_t’ {aka ‘long long int’} [-Werror=format=]
   66 | #define blog(level, msg, ...) blog(level, "v4l2-input: " msg, ##__VA_ARGS__)
      |                                           ^~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/plugins/linux-v4l2/v4l2-input.c:262:17: note: in expansion of macro ‘blog’
  262 |                 blog(LOG_DEBUG,
      |                 ^~~~
cc1: all warnings being treated as errors
[137/484] /usr/bin/cc -DENABLE_HEVC -DHAVE_OBSCONFIG_H -Dlinux_jack_EXPORTS -I/<<PKGBUILDDIR>>/libobs -I/<<PKGBUILDDIR>>/obj-arm-linux-gnueabihf/config -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/obs-studio-30.0.2+dfsg-2.1build2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=3 -DFFMPEG_MUX_FIXED=\"/usr/lib/arm-linux-gnueabihf/obs-plugins/obs-ffmpeg/obs-ffmpeg-mux\" -DSIMDE_ENABLE_OPENMP -fopenmp-simd -O3 -fvisibility=hidden -Wno-error=deprecated-declarations -std=gnu17 -fPIC -Werror -Wextra -Wvla -Wno-error=vla -Wswitch -Wno-error=switch -Wformat -Wformat-security -Wunused-parameter -Wno-unused-function -Wno-missing-field-initializers -fno-strict-aliasing -Werror-implicit-function-declaration -Wno-missing-braces -Wno-error=maybe-uninitialized -DSIMDE_ENABLE_OPENMP -fopenmp-simd -MD -MT plugins/linux-jack/CMakeFiles/linux-jack.dir/linux-jack.c.o -MF plugins/linux-jack/CMakeFiles/linux-jack.dir/linux-jack.c.o.d -o plugins/linux-jack/CMakeFiles/linux-jack.dir/linux-jack.c.o -c /<<PKGBUILDDIR>>/plugins/linux-jack/linux-jack.c


I did "fix" with an ugly hacky patch, just for armhf platform, but I don't know how to properly solve it.

diff -Nru obs-studio-30.0.2+dfsg/debian/patches/time64.patch obs-studio-30.0.2+dfsg/debian/patches/time64.patch
--- obs-studio-30.0.2+dfsg/debian/patches/time64.patch	1970-01-01 01:00:00.000000000 +0100
+++ obs-studio-30.0.2+dfsg/debian/patches/time64.patch	2024-03-22 13:31:40.000000000 +0100
@@ -0,0 +1,18 @@
+Description: Use time64_t everywhere
+Author: Gianfranco Costamagna <locutusofborg@debian.org>
+Last-Update: 2024-03-21
+
+--- obs-studio-30.0.2+dfsg.orig/plugins/linux-v4l2/v4l2-input.c
++++ obs-studio-30.0.2+dfsg/plugins/linux-v4l2/v4l2-input.c
+@@ -260,7 +260,11 @@ static void *v4l2_thread(void *vptr)
+ 		}
+
+ 		blog(LOG_DEBUG,
++#ifndef __arm__
+ 		     "%s: ts: %06ld buf id #%d, flags 0x%08X, seq #%d, len %d, used %d",
++#else
++		     "%s: ts: %06lld buf id #%d, flags 0x%08X, seq #%d, len %d, used %d",
++#endif
+ 		     data->device_id, buf.timestamp.tv_usec, buf.index,
+ 		     buf.flags, buf.sequence, buf.length, buf.bytesused);
+

--- End Message ---
--- Begin Message --- 
Source: obs-studio
Source-Version: 30.0.2+dfsg-3
Done: Benjamin Drung <bdrung@debian.org>

We believe that the bug you reported is fixed in the latest version of
obs-studio, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1067494@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Benjamin Drung <bdrung@debian.org> (supplier of updated obs-studio package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 31 Mar 2024 15:13:19 +0200
Source: obs-studio
Built-For-Profiles: noudeb
Architecture: source
Version: 30.0.2+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Benjamin Drung <bdrung@debian.org>
Closes: 1067494
Changes:
 obs-studio (30.0.2+dfsg-3) unstable; urgency=medium
 .
   * Team upload.
   * Fix build on 32bit time64_t archs. Thanks to Gianfranco Costamagna.
     (Closes: #1067494)
   * linux-v4l2: Save device by ID or path to make webcam ordering persistent
     (to support having multiple in the system). Fixes upstream bug 3003.
   * Add simple autopkgtest that just calls obs --help and --version
Checksums-Sha1:
 a9d9a499674345958553821ef608d401098133a9 3656 obs-studio_30.0.2+dfsg-3.dsc
 1636832a55ffd380bae6bb32c48ba06980d05341 61056 obs-studio_30.0.2+dfsg-3.debian.tar.xz
 d135c707c93ff486009efe04b52068daf249c451 11355 obs-studio_30.0.2+dfsg-3_source.buildinfo
Checksums-Sha256:
 760220b0e9790adc5511cdf3dfc68908e92b4f30e67a910d4a5967cfb8a48549 3656 obs-studio_30.0.2+dfsg-3.dsc
 6760ee7f1849dd20c8b45397ec8f08ff1882ebab0af4e20b5dc62ae3c0587500 61056 obs-studio_30.0.2+dfsg-3.debian.tar.xz
 23c64adfd5c3b27f7c2716089dbe3e5f94527a66a22ddd76822abac68244c59f 11355 obs-studio_30.0.2+dfsg-3_source.buildinfo
Files:
 6307e3a0a62ef9e99618ba853228a34e 3656 video optional obs-studio_30.0.2+dfsg-3.dsc
 330c3fa912a50ba2d20edfeb11d4f30c 61056 video optional obs-studio_30.0.2+dfsg-3.debian.tar.xz
 86bd2002190c53ffc8ff0ae5dd06c1d9 11355 video optional obs-studio_30.0.2+dfsg-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEpi0s+9ULm1vzYNVLFZ61xO/Id0wFAmYJYxIACgkQFZ61xO/I
d0xkZA/+MVN0k3A/u3pIhUK4GqMbEUgqRpfYKaCIucLRcRoFWwbQNK8q68iebh/T
2RFdbeq/Z5CS8vJVEQBUzgl4y7h9pYKGEB7T7nNMiNj8uDFD2wrSkc1aQ9t7mVZF
KDjYYIernbZbPeSkDKchtgos7qs2fc+hE2biCSByM/QtKg3QBV1bdObIGr35ktRJ
FdmCDl8G1qjLAzq/H6TgeKwKtJGIkXIq/dHd5tkhCkk5BRNfhGrVdt/SbLHWSOVd
XD5JzMzeKMmlOgahQrig+BSg9wLptN/KCnyc2fKAiLCahYTROgyvqstvXkkBn7DC
KhjhQTHnbXat+m3GXo+FFJo88W8RppCGM9bG2EY9Gq/MBV7HZNIPaUGSERjrZBh3
1heIT1OLktI1DTJ6Vo+bJ0O+Kn4TvDYW1wSvR+9B5rT0Bmu/T1ykFCSbT8agyZYH
01VRXElSAngIZaR+dtqt+5agoOsUjUYXPY9OZ1YkoLL1zfSWVg1rxXzi55tVcqGV
rmvWfIYRN83A3Fh5OrP/cOZgK0Qwj2kNFr1rwNnR/xrc7jhhsKOUtKEXVOQ0Lgr+
svTsxZn7MR8GqMaaznOVZ8IbX/f/DNFLWWVaq54vAldabpAJaovET8mRyrBhwxCk
fMwLVv5faOL/GH6xYbQ+D93i4s73/TuQEkOcnx0X+P6274rnEYc=
=0+MA
-----END PGP SIGNATURE-----

Attachment: pgpJlpTc3u4gO.pgp
Description: PGP signature


--- End Message ---
Reply to: