[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: change LED behavior on Qube2



Hi Sameer, Martin,

On Thursday 19 November 2009 23:37:53 Florian Fainelli wrote:
> Hi Sameer, Martin,
> 
> Le mardi 17 novembre 2009 21:49:52, Martin Michlmayr a écrit :
> > * Sameer Verma <sverma@sfsu.edu> [2009-09-14 11:51]:
> > > I noticed that on Lenny for Qube2, the green LED flickers with disk
> > > activity, but stays 'off' otherwise. Can this be changed to a constant
> > > 'on' like before? I kinda like my office to be bathed in the eerie
> > > green glow at night :-)
> >
> > I don't have a Qube2 so I cannot test it, but the following should
> > work:
> >
> > modprobe ledtrig-default-on
> >
> > # 2.6.31 and lower
> > echo default-on >
> >  /sys/devices/platform/cobalt-qube-leds/leds/qube-front/trigger
> >
> > # 2.6.32 and higher
> > echo default-on >
> >  /sys/devices/platform/cobalt-qube-leds/leds/qube::front/trigger
> 
> We might want the following patch to restore the usual behavior, if it
> is fine with you I can send this upstream.
> ---
> diff --git a/drivers/leds/leds-cobalt-qube.c
>  b/drivers/leds/leds-cobalt-qube.c index 8816806..81b2014 100644
> --- a/drivers/leds/leds-cobalt-qube.c
> +++ b/drivers/leds/leds-cobalt-qube.c
> @@ -31,7 +31,7 @@ static struct led_classdev qube_front_led = {
>  	.name			= "qube::front",
>  	.brightness		= LED_FULL,
>  	.brightness_set		= qube_front_led_set,
> -	.default_trigger	= "ide-disk",
> +	.default_trigger	= "default-on",
>  };
> 
>  static int __devinit cobalt_qube_led_probe(struct platform_device *pdev)

FYI, this got merged upstream, so the default LED behavior is to stay solid, 
one might still use a different trigger afterwards.


Reply to: