Bug#1041327: RFS: libtypec/0.3-1 [RFP] -- Development files for an interface for USB-C port management

["Colin King (gmail)" <colin.i.king@gmail.com>]

Hi Balint,


On 16/11/2023 18:55, Bálint Réczey wrote:
> Hi Colin,
>
> Colin King (gmail) <colin.i.king@gmail.com> ezt írta (időpont: 2023.
> nov. 16., Cs, 17:46):
> > Hi Balint,
> > > Since libtypec installs include files and libs to the standard
> > > locations actually there is no need to set those paths.
> > > I think I would use the following patch:
> > >
> > > --- a/libtypec.pc.in
> > > +++ b/libtypec.pc.in
> > > @@ -1,12 +1,9 @@
> > >    prefix=/usr
> > >    exec_prefix=/usr
> > > -libdir=${exec_prefix}/lib/x86_64-linux-gnu
> > > -includedir=${prefix}/
> > >
> > >    Name: libtypec
> > >    Description: USB-Type C and USB Power Delivery class devices
> > >    Version: 0.4.0
> > >
> > >    Requires:
> > > -Libs: -L${libdir} -llibtypec
> > > -Cflags: -I${includedir}
> > > +Libs: -llibtypec
>
> I think this patch application did not work out as intended, please
> check the patched file.
>
> The symbols file's first line is also still off and now the symbos
> have debian package revisions.
>
> Those are issues automatically detected by Lintian. I suggest running
> lintian on the built binary packages' .changes file or populating the
> packaging repository on Salsa where CI runs include lintian and many
> other checks.

I ran lintian but I didn't see the errors, I used:

lintian --profile=debian --pedantic libtypec_0.4-3_source.changes

perhaps there are some extra lintian flags or config settings that I'm 
missing. Any suggestions?

Colin



> Cheers,
> Balint
>
> > Ah, good idea. I've refreshed package with this change. Also updated the
> > .symbols file and uploaded a -4 to mentors.
> >
> > Colin