Hi, 在 2023-09-24星期日的 02:38 -0400，Yogu NY3W写道： > Hi Boyuan, > I want to express my appreciation for your valuable feedback. Your insights have been immensely helpful in improving the package, and I've made several important changes. > > 1. I have removed empty conffiles. > > 2. Implemented dh_installcron to manage the crontab within /etc/cron.d/ for a safe and reliable approach. > > 3. Removed the "Name" field in the upstream/metadata to adhere with the current guidelines. > > 4. Invasive manipulation of system files has been avoided, using dh_installsystemd, and others to manage these files appropriately. > > 5. Eliminated wrapper, preinst and postinst scripts. Eliminated the need for mkdir -p and adopted dh_installdirs and dh_installdocs. Significantly minimized the use of > postinst and postrm scripts to adhere to best practices. > > 6. Revised Nginx configuration handling. I've carefully redesigned the handling of Nginx configurations to ensure that default Nginx settings are not overwritten, thus > safeguarding any user-modified configurations. > > Throughout this process, I've looked into other debian system packages to ensure that this package aligns with Debian standards. I would greatly appreciate your review of > these changes and any further guidance. I look forward to your continued support. I belive the following issues still need to be fixed: * debian/a2d.init.d still refers to files under /usr/local/, which I believe does not exist. * Why are you installing /etc/nginx/ssl/ as an empty directory? Is this directory used by your program anywhere? If not, please do not have it installed. The following issues are not required to fix: * I am curious on your thought of installing files under /usr/share/scripts/. This kind of practice never appeared in Debian's past packages, and I never saw it in other software. Would using /usr/share/a2d/scripts/ be a better choice? * Please consider fixing the following lintian warnings: W: a2d: skip-systemd-native-flag-missing-pre-depends (does not satisfy init-system-helpers:any) [postinst:24] W: a2d: skip-systemd-native-flag-missing-pre-depends (does not satisfy init-system-helpers:any) [prerm:10] You may google the warning messages for more information. Thanks, Boyuan Yang
Attachment:
signature.asc
Description: This is a digitally signed message part