[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010642: RFS: streamlink/4.0.1-1 -- CLI for extracting video streams from various websites to a video player



Control: tags -1 - moreinfo

Hi,

Thanks for your review :)

Le 07/05/2022 à 18:59, Jeroen Ploemen a écrit :
> Control: tags -1 moreinfo
> 
> On Thu, 5 May 2022 23:34:43 +0200
> Alexis Murzeau <amubtdx@gmail.com> wrote:
> 
>> I am looking for a sponsor for my package streamlink for a new
> 
> hi Alexis,
> 
> the package as published on mentors ftbfs for me, looks like it's
> trying to connect to the internet for something to do with intersphinx
> (docs/conf.py:110 ?). See log excerpt [1] below.

Indeed, I was running sbuild locally, but it doesn't prevent internet access.


> 
> Other than that, a few observations:
> * control: ancient version requirements for python, requests, and
>   pycountry are always met (even in oldstable);

I've removed old versions requirements always met (up to oldoldstable).


> * vcs: consider enabling the CI on Salsa, and pushing changes to
>   git before asking for sponsorship - it's a useful quality control
>   tool and a nice timesaver for reviewers too.
> 

I've enabled CI on Salsa (and pushed, which I forgot to do previously).
Everything is building Ok except the reprotest job which is failing because of multiple issues that I haven't fully investigated.
There is at least:
  - Hang in python 3.10 because of faketime, probably because faketime is not complete [1]
  - Crashes in lxml with unusual LC_ALL (maybe encoding related) (I need to report the bug for this)
  - Something else that crashes too and cause a core file to be generated and reported by dh_missing [2]


[1] https://github.com/wolfcw/libfaketime/issues/390
[2] usr/lib/python3.10/dist-packages/core

> 
> Please remove the moreinfo tag (and CC me directly) once you have an
> updated package ready.
> 

-- 
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F                |

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: