[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#895262: RFS: deepin-menu/3.3.2-1



On Mon, Apr 09, 2018 at 10:31:30AM +0800, Yanhao Mo wrote:
> * Package name    : deepin-menu
>   Version         : 3.3.2-1

(Note: there's a couple transitions going on, so installability of build
dependencies comes and goes, causing temporary problems; this is not your
fault.)

> Changes since the last upload:
>   * New upstream release.
>   * d/control: add new uploader Yanhao Mo <yanhaocs@gmail.com>
>   * d/control: Use Salsa platform for Vcs field.
>   * debian/control: Update Standers-Version to 4.1.4.
>   * debian/compat: Switch compat to level 11.

Hi!
I see that the packaging no longer installs autostart parts:

--- deepin-menu-3.2.0/debian/install    2017-08-11 15:49:21.000000000 +0200
+++ deepin-menu-3.3.2/debian/install    1970-01-01 01:00:00.000000000 +0100
@@ -1,2 +0,0 @@
-data/com.deepin.menu.service /usr/share/dbus-1/services/
-deepin-menu.desktop /etc/xdg/autostart/

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /etc/xdg/autostart/deepin-menu.desktop
-rw-r--r--  root/root   DEBIAN/conffiles

It's a non-obvious packaging change that would be nice to be described in
the changelog.

On the other hand, DDE wasn't a part of Stretch (so not many users yet), and
for your internal purposes, it's in git:
https://github.com/linuxdeepin/deepin-menu/commit/09e65bd7bd46c9aa6cdd1b205aa4e4f7be33ef0c
so if you feel like I'm nitpicking too much, please tell me so, I can upload
as-is.


Speaking about nitpicks in the changelog: s/Standers/Standards/.

Thanks for your work!


喵!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢰⠒⠀⣿⡁ 
⢿⡄⠘⠷⠚⠋⠀ ... what's the frequency of that 5V DC?
⠈⠳⣄⠀⠀⠀⠀


Reply to: