[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

review eject 2.1.5+deb1+cvs20081104-13.1 2014-02-14 21:29



Hi Gianfranco,

I have two questions for you.

1. The patch makes the program use one additional position of the memory
pointed to by buf.  Are you sure that there will be no buffer overflow for any
value of name without replacing 14 by 15 in the allocation ?

2. The package has a high popcon.  Have you thoroughly tested the resulting
package ? I would feel more comfortable if you would confirm that on bug
719110.

Regards,

Bart Martens


Reply to: