[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ngp/0.1-1.0 [NMU]



Hallo Jonathan,

(first the usual disclaimer: I'm not a DD so I cannot sponsor.)

I only briefly look into the packaage , so this is only a brief review
mostly from the data available from m.d.n... Sorry, also on a hurry ..


I see those problems which should work on:
-> you need to file an ITP Bug against wnpp and you cannot have a NMU
with an initial upload.
-> you have lintian warnings in your package, please fix them
-> your debian/control lacks the homepage field
-> d/copyright is incomplete, you should read
http://dep.debian.net/deps/dep5/ as this format is strongly recommended.
-> d/README.source is still a template. Edit or remove.
-> d/README.Debian is probably not needed, or are there Debian
specilities?
-> as you are using autoconf and friends, you should also use
dh_autoreconf in your rules.
-> There is no source for "search.png". Is this image indeed needed?
-> debian/patches is empty and should be removed
-> debian/ngp.1 should be included upstream (as you are upstream this is
easy)
-> you need to have a watch file (if you release) or an get-orig-source
target in debian/rules to regenerate the tarball.

A personal opinion: "ngp" is a little short for a package / binary name,
as this kind of pollutes the namespace (and there is a ngp2 in the
archives). Maybe consider a more self-explaining name?


Best regards,

-- 
coldtobi

Am Sunday, den 16.02.2014, 15:28 +0100 schrieb Jonathan Klee:
> Package: sponsorship-requests
> Severity: normal 
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "ngp"
> 
>  * Package name    : ngp
>    Version         : 0.1-1.0
>    Upstream Author : Jonathan Klee
>  * URL             : https://github.com/jonathanklee/ngp
>  * License         : GPL
>    Section         : devel
> 
> It builds those binary packages:
> 
>     ngp   - Ncurses code parsing tool
> 
> To access further information about this package, please visit the following URL:
> 
>   http://mentors.debian.net/package/ngp
> 
> 
> Alternatively, one can download the package with dget using this command:
> 
>     dget -x http://mentors.debian.net/debian/pool/main/n/ngp/ngp_0.1-1.0.dsc
> 
> More information about hello can be obtained from https://github.com/jonathanklee/ngp
> 
>   Changes since the last upload:
> Initial release.
> 
> Best regards,
> Jonathan Klee


Reply to: