Bug#717360: Review for RFS: niceshaper/1.0.0-2 [ITP]

[Mariusz Jedwabny <mariusz@jedwabny.net>]

Hi Johann.

Thank you for reviewing of my package.

Yesterday i uploaded new version to mentors according to your 
suggestions.


W dniu 2013-09-29 19:30, Johann Felix Soden napisał(a):
> Hi Mariusz,
>
> here a short review of your niceshaper package on mentors.d.n (might
> not be complete):
>
> - COPYING and debian/copyright do not match: Is your software GPL-2
> or "GPL-2+", which means "GPL v2 or later"?

Fixed: NiceShaper is GPL-2.

> - remove trailing whitespaces in debian/ files (use egrep '\s$'  
> debian/*).
>
> - remove the comments at the beginning of debian/rules about its 
> dh-make origin.

Both fixed.

> - fix lintian warnings:
>
>   W: niceshaper source: out-of-date-standards-version 3.9.3 (current 
> is 3.9.4)

Bumped to 3.9.4

>   W: niceshaper: hardening-no-relro usr/bin/niceshaper
>   I: niceshaper: hardening-no-fortify-functions usr/bin/niceshaper
>   -> Enable hardening: switch to debian/compat 9 and adapt the
> makefiles accordingly: they should append to
>      the build flags. The code does not compile with
> -Werror=format-security so you need either overwrite this flag or
>      fix your code.

I made a patch introduce_hardening.patch as it was faster than makeing 
new upstream release.
Binary is these warnings free and of course compile properly now.

>  - As it seems that the configuration of niceshaper needs to be
> adapted nearly everywhere,
>    it does not make much sense to start it automatically with some
> example settings.
>    Therefore I recommend you to disable it by default (add a
> commented /etc/default/niceshaper
>    file with something like NICESHAPER_ENABLE=false and check it in
> the init.d script).
>    Add a README.Debian which describe what the user needs to do to 
> enable it.
>
>    But maybe you have a better idea, how to improve the usage for 
> normal user.

In previous version i put dh_installinit --no-start in debian/rules but 
it was not the full solution what i realized.
Your suggestion is great addition.
I added /etc/default/niceshaper and README.Debian with explanation and 
introduce NICESHAPER_ENABLE option to initscript.
When some one try to run niceshaper and NICESHAPER_ENABLE is no they 
get warning with hint:

NiceShaper not enabled in /etc/default/niceshaper


>  - bonus (optional): support vim-addon-manager (add
> /usr/share/vim/registry/niceshaper.yaml, see
>    /usr/share/doc/vim-addon-manager/addons-proposal.txt for details).

I didn't know vim-addon-manager, sounds interesting. But for now can i 
omit implementing this feature as it is bonus?
I will come back to this feature in the future.

Best regards
Mariusz Jedwabny