Bug#662955: RFS: rubyripper/0.6.2-1 [ITP]

[Paul Wise <pabs@debian.org>]

You might want to join #debian-au :)

Have you considered joining the multimedia team?

https://wiki.debian.org/Teams/Multimedia

I don't intend to sponsor this package, but here is a review:

Please get the patches include upstream and or change them to be
acceptable upstream.

Please use this watch file instead:

version=3
opts=uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha|b|a)\d*)$/$1~$2/
\
 http://code.google.com/p/rubyripper/downloads/list?can=1 \
 .*/rubyripper-(\d\..+)\.(?:zip|tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz)))

Please call dh_auto_configure in override_dh_auto_configure instead of
./configure, this will allow you to drop --configure.

There doesn't seem to be a need for the rubyripper.png symlink, what
is that needed for?

The comments in the manual page aren't needed.

Please get the manual page included upstream.

Please run wrap-and-sort -sa so diffs of debian/* are more human-readable.

The package descriptions are almost duplicates of each other.

The SVG source for rubyripper.png is missing from the package.

The upstream README contains install and MacOS information, please ask
upstream to split that out into separate files since it isn't useful
for Debian users.

Several of the files in the source are executable, but do not need to be.

I'm not familiar with ruby, but the way it uses popen doesn't look safe to me.

Automatic checks:

https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package

ruby configure --update-lang:

lots of obsolete msgid warnings

lintian:

P: rubyripper-gtk2: no-upstream-changelog
P: rubyripper-cli: no-upstream-changelog

cme check dpkg-control:

Says that the short descriptions for the packages are too long.

msgfmt:

many empty msgstr warnings

POFileChecker:

lots of warnings:
missing :
missing .
missing ...
extra \n

-- 
bye,
pabs

http://wiki.debian.org/PaulWise