Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit

To: 667904@bugs.debian.org
Subject: Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit
From: Jakub Wilk <jwilk@debian.org>
Date: Tue, 8 Jan 2013 02:06:49 +0100
Message-id: <[🔎] 20130108010649.GA2455@jwilk.net>
Mail-followup-to: 667904@bugs.debian.org
Reply-to: Jakub Wilk <jwilk@debian.org>, 667904@bugs.debian.org
In-reply-to: <[🔎] 50E4C098.2030606@gmail.com>
References: <4F80256D.2030805@gmail.com> <20121231202124.GA633@jwilk.net> <[🔎] 50E3821A.3050200@gmail.com> <[🔎] 20130102223302.GA6417@jwilk.net> <[🔎] 50E4C098.2030606@gmail.com>

Does debian/patches/compilation_fixes really fix only "compilation onDebian systems"?


I see several problems with the __fls function:
- You can't use "__" in your own identifiers; such names are reserved.
- The implementation uses x86 assembly.
- The unsigned long -> int typecast looks redundant to me.

Typo in src/optimize/lbfgs.f: THE THE -> THE.
Typo in src/optimize/lbfgsb.f: easible -> feasible.

--
Jakub Wilk

Reply to:

References:
- Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit
  - From: Giulio Paci <giuliopaci@gmail.com>
- Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit
  - From: Jakub Wilk <jwilk@debian.org>
- Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit
  - From: Giulio Paci <giuliopaci@gmail.com>

Prev by Date: Bug#695366: RFS: gringotts/1.2.10-1
Next by Date: Bug#689692: marked as done (RFS: byzanz/0.3.0+git20120930-1 [ITA])
Previous by thread: Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling toolkit
Next by thread: Processed: libgetoptionkit-php: block ITP 696183 by RFS 697142
Index(es):
- Date
- Thread