On Mon, 24 Dec 2012 00:45:40 +0100, Steffen Vogel wrote: > thanks for reviewing my package! I've fixed all points you mentioned. That was quick :) > There still the problem that the package name (sun) might be too generic > to be included in the archive. What do you think about this concern? To be honest, I also had this concern when I read your first mail on -mentors. Something less generic might be nice if we come up with a good idea. > I've collected some alternatives: > > solar > suncal > atsun > sunrun > suncycles - makes no sense to me suncal(c) would be my favourite at the moment. <brainstorming mode> Before sunset (movie title) From dusk till dawn something with 'rise' and 'set' Rise and Shine! twiglight (since it's an option) </> > Am Sonntag, den 23.12.2012, 23:17 +0100 schrieb gregor herrmann: > > - The package doesn't build on a machine / in a chroot without > > internet access because the tests fail: > fixed. I moved the binary from the check_ prefix to the noinst_ prefix. > So it gets compiled for testing purposes but not installed by automake. Yup, works. > > - You can remove the override_dh_auto_configure in debian/rules if > > you use debhelper (>= 9) in debian/control and 9 in debian/compat. > fixed. Purely aesthetic remark: You used "debhelper (>= 9.0.0)" now. The additional minor version has no benefit over a plain "(>= 9)". (It also doesn't hurt to the best of my knowledge.) > > - Please run lintian with all bells and whistles turned on against > > the .changes file. It reports for me: > > debian-watch-contains-dh_make-template and > > 3x hyphen-used-as-minus-sign for the manpage > fixed. I've run lintian with --pedantic -E. No more warnings are showing > up. Perfect! > Just debian-mentor's lintian claims: > newer-standards-version 3.9.4 (current is 3.9.3) Well, yes, looks like someone should update lintian on mentors.d.n :) > > - Installing the empty NEWS file doesn't look so helpful :) > > (And I'd rename docs to sun.docs for consistency with > > sun.manpages.) > fixed. Automake requires the NEWS file. So, I removed it from > debian/sun.docs. Yup, that was my idea. One last nitpick: The example with Berlin in the manpage seems to have wrong coordinates; --lat=50.55 --lon=-6.2 is in the Atlantic between Britanny and Cornwall (or Finistère and Land's End). Ok, so let's think a bit about the name, and maybe somone else wants to take a look at the package, but basically this looks all very good already. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Mark Knopfler: Sailing To Philadelphia
Attachment:
signature.asc
Description: Digital signature