Bug#693330: RFS: mathjax/2.1+20121028-1 mathjax-docs/2.1+20121030-1
On Mon, Dec 17, 2012 at 5:10 AM, Dmitry Shachnev <mitya57@gmail.com> wrote:
> Hi Andrew, thanks for your review.
>
> On Mon, Dec 17, 2012 at 5:16 AM, Andrew Starr-Bochicchio <asb@debian.org> wrote:
>> 2) The debian/copyright file has a few small issues with the spec.
>>
>> - SIL Open Font License (OFL), Version 1.1. should just use the short
>> name OFL-1.1 in the License field.
>>
>> - As it isn't among the common-licenses, you need to include the full
>> text of the OFL-1.1.
>>
>> - Optionally, you can use stand-alone license paragraphs for a given
>> license once, instead of repeating it in each Files paragraph that
>> refers to it. Also, you could combine the Files paragraphs for the
>> files that share the same license and copyright holder. I.e.
>>
>> Files: fonts/HTML-CSS/TeX/eot
>> fonts/HTML-CSS/TeX/otf
>
> Added full license text (about 100 lines...). I don't think I can use
> the short name as it is not listed in the specification:
> http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name.
My personal understanding is that when not listed in the
specification, the SPDX identifier should be used. Though that doesn't
seem clear in the text at all. May I'll bring this up on
debian-policy. As another data point, the only machine-readable
debian/copyright parser I know warns on your language but not OFL-1.1
$ cme check dpkg-copyright
Configuration item 'Files:"fonts/HTML-CSS/TeX/eot" License short_name'
has a wrong value:
value 'SIL Open Font License (OFL), Version 1.1.' does not match grammar:
I certainly won't block uploading on this.
>> But all that's a bit nit-picky. Now lets look at the doc package:
>> 3) You have no debian/watch file.
>
> The docs repository doesn't have any tags at all (I guess it's
> supposed to be a "rolling" branch), so no watch file for now.
While a 2.1 release doesn't seem to exisit, older tags are availiable
for download at:
https://github.com/mathjax/mathjax-docs/tags
Either way, I like to follow the advise offered by the lintian tag:
N: If the package is not maintained upstream or if upstream uses a
N: distribution mechanism that cannot be meaningfully monitored by uscan
N: and the Debian External Health Status project, please consider adding a
N: debian/watch file containing only comments documenting the situation.
If there isn't a working debian/watch, I'd also like to see a
get-orig-source target in debian/rules.
Thanks,
-- Andrew Starr-Bochicchio
Ubuntu Developer <https://launchpad.net/~andrewsomething>
Debian Developer <http://qa.debian.org/developer.php?login=asb>
PGP/GPG Key ID: D53FDCB1
Reply to: