Hi David, I think we are nearly there. It seems upstream decided to use a slightly different patch than you currently use for bug 692272. Could you comment on the differences? http://sourceforge.net/p/liferea/code/ci/a167cec01b086302854ec4908ad92210b438c3e0/tree/src/itemlist.c?diff=13b09aee142529b64a73c8e25b4b40d817f354b4 >>> diff -Nru liferea-1.8.6/debian/control liferea-1.8.6/debian/control >>> - libwebkit-dev (>= 1.2.2), >>> + libwebkitgtk-dev (>= 1.8.1), >> Although I suggest to remove it now, why also update the version? This >> is not documented in the changelog. > > I set the version to the libwebkitgtk-dev that is in Wheezy. I noticed > that older versions of libwebkit & libxml2 cause problems because when > libwebkit or libxml2 crashes, it always causes liferea to crash. There > were a bunch of bug reports that got tracked back to old versions of > libwebkit or libxml2 (#551147) and I suspect several others are related > to old versions of those libs as well (#583990, #609494, #645423). I > don't have any bug reports as specifically being marked as resolved-by > having a newer version of the lib though. > > Though I'll admit it's certainly not *required* to have the new version > so I removed the increase in the version number from the NMU. If you are confident that it is better to use a newer version, you can do so, but then you have to document it in the changelog. And for possible backports, it would than be better to give the minimal version you are comfortable with, not just the current version. For now, leaving the version as it was seems best to me. > Note: Upstream has just contacted me saying that they accepted a slight > modification of my patch. > I've replaced this patch with upstream's modified patch[0]. I had > forgot to free a variable after using it. Ack. Just a note, next time you can leave the forwarded-to notes in the bts. They are links to the upstream bug, whether or not they are fixed upstream is irrelevant for the tag. Paul
Attachment:
signature.asc
Description: OpenPGP digital signature