Bug#684434: RFS: yamcha/0.33-1 [ITP] -- General purpose chunker annotator
Il 02/12/2012 15:56, Jakub Wilk ha scritto:
> * Giulio Paci <giuliopaci@gmail.com>, 2012-12-01, 20:45:
>> I decided to push my git repository to collab-maint. You can find it here:
>>
>> Vcs-Git: git://git.debian.org/git/collab-maint/yamcha.git
>> Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/yamcha.git
>
> Great. If you don't keep the package on mentors.d.n up-to-date (which is fine to me; I prefer the VCS), please remove it from there.
Removed.
>>> "spro", what's that?
>> Just a cut-and-paste error.
>
> There's still once instance of it:
> pkgdatadir=${datarootdir}/spro
Removed.
> The .pc file has "Requires: tinysvm". I see several problems with this:
After double-checking, I noticed that tinysvm is not a "library" requirement: only binaries are used.
> 1) It should probably be Requires.private, not Requires.
I removed this line as it is not needed.
> 2) libyamcha-dev should depend on libtinysvm-dev.
I removed build-time dependency on libtinysvm-dev: only tinysvm is required.
> 3) libtinysvm-dev doesn't ship a .pc file
I will try to add one for tinysvm as well, as it may be useful.
> I'd start short description with a lowercase letter; see Developer's Reference §6.2.2.
Fixed.
> I tried building the package with DEB_BUILD_OPTIONS=noopt. The compile command-line looked like this:
>
> g++ -DHAVE_CONFIG_H -I. -I.. -I../src -D_FORTIFY_SOURCE=2 -g -O0 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -O3 -Wno-deprecated
> -Wall -c -o mkdarts.o mkdarts.cpp
>
> There are both -O0 and -O3 here, and if I understand it correctly, the last options wins.
I updated the 1004_autoconf_fixes.patch so that now everything should work properly. The same issue is also present in tinysvm. I will fix it as soon as possible.
Bests,
Giulio.
Reply to: