On Thu, Sep 27, 2012 at 05:10:09AM +0000, Bart Martens wrote:
> Hi Albert,
>
> I looked at the package uploaded to mentors on 2012-09-27 00:31.
Albert came on IRC, and was so enthusiastic I had a look too
These are comments I've also expressed on IRC, but I'm just putting them
on the record here. They're also in addition to Bart's comments (which
are, as usual, fantastic)
I believe this should target experimental, not unstable - this is a new
upstream release with a lot of changes (can't remember of what order it
was, but either 8K or 80K lines in the debdiff)
There are also fixes that are not minimal in the upload, so I'd
encourage three points:
- Before any sponsor uploads this, please get a statement from the
release team ACKing (in theory, at least) this change.
- If they refuse to allow this to migrate, please retarget to
experimental. Please also take a look to see if you may port some of
the bugfixes you're introducing here back to the old code.
- If they allow it, it'd be nice to poke this thread to let us know :)
>
> On Wed, Sep 26, 2012 at 09:49:39PM -0400, Albert Huang wrote:
> > Before that Bart Martens wrote:
> > > I read this in README :
> > >
> > > | (A special exception applies when linking the library into TilEm, see
> > > | the COPYING file for details.)
> > >
> > > But I don't find such exception in COPYING. Actually, the file COPYING is
> > > identical to /usr/share/common-licenses/GPL-2 so there's nothing specific
> > > to "linking the library into TilEm" in COPYING.
> > >
> > Upstream confirms that this exception no longer applies, and as you've said
> > COPYING does not have said exception. I've added a patch to remove that
> > confusing clause.
>
> I read this in debian/patches/remove-tilem-copyright-exception.patch :
>
> | Description: remove tilem copyright exception
> | Removes the now invalid TilEm copyright exception from the README, since the
> | LICENSE file makes no mention of it, and upstream confirms that this exception
> | is no longer valid.
> | Author: Albert Huang <alberth.debian@gmail.com>
>
> But there is no LICENSE file. I guess you meant the COPYING file.
>
> I suggest to not patch README but to quote what upstream wrote about this in
> debian/copyright including upstream's From and Date headers.
>
> Regards,
>
> Bart Martens
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: http://lists.debian.org/20120927051009.GB20306@master.debian.org
>
--
.''`. Paul Tagliamonte <paultag@debian.org>
: :' : Proud Debian Developer
`. `'` 4096R / 8F04 9AD8 2C92 066C 7352 D28A 7B58 5B30 807C 2A87
`- http://people.debian.org/~paultag
Attachment:
signature.asc
Description: Digital signature