Bug#665823: RFS: libapache2-mod-geoip/1.2.7-1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello Nigel,
On 26.03.2012 14:05, Nigel Jones wrote:
> I am looking for a sponsor for my package "libapache2-mod-geoip"
thanks for your contribution. As I can't sponsor packages, take the
following hints as a review only:
First, let me inform you, you should prepare another version of your
package which works with Apache 2.4, available in experimental. That
one is going to replace Apache 2.2 in Debian Sid pretty soon. However,
this breaks all module packages and they need some source tweaks.
Please read [1][2][3] for more information about this as this is going
to affect you really soon.
I think it would be best to get this version into Wheezy now, and
focus on the 2.4 module package afterwards, perhaps even by doing an
upload to experimental.
mod_geoip probably does not work without GeoIP database installed. You
should recommend the geoip-database at least. I realize there are
proprietary databases available, thus my suggestion to use a weaker
recommends constraint.
Do you have any public version control system to maintain your
package? If yes, add Vcs-Browser and Vcs-(Git|Svn|...) fields to your
control file.
In your maintainer script you should call a2enmod/a2dismod with the -q
argument. And while you're at it you could perhaps safe some CPU
cycles by changing the shell to /bin/sh (you need to avoid bashisms
then of course).
Your debian/rules file looks fairly ok, but wasn't updated in this
century. Maybe upgrade to the newer short dh format which makes it
much less probably that you're forgetting something or your package
breaks in a unforeseeable future.
Maybe you could also omit the last sentence in the package description
as we're not shipping anything but Apache 2 since almost a decade or so.
[1] https://lists.debian.org/debian-devel-announce/2012/03/msg00013.html
[2] http://wiki.debian.org/Apache/PackagingFor24
[3]
http://anonscm.debian.org/gitweb/?p=pkg-apache/apache2.git;a=blob;f=debian/PACKAGING;hb=next
- --
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJPcHIeAAoJEMcrUe6dgPNtDeIQAM535PKtLP0gf3SiktOHX6bo
NjlSN7jpz9FSihZ929lsmtbafW/SLe9H48RKjlEk691jFw6KvJXhs5l+ga2VPisv
lRSj+0QNi46J03iCnqvlCqt2OKP2hw48fyllPmHzW0O8ZnRPt61ITvEwLLcRc1+I
KAMrPaZnZkbpLvQMrXthjvyeV4VyHTjgxsWyoIwgJURQjevv61WhSMbzu5xFCqGu
WVgdikswLXkwRZQoBDMtwdZ5fQxJ7TITRqBiMFiVOcRZkCaM77yEDEfe+Fj5uEDf
WAU3f6qPYVjpM3niGfCp15NKyUF23wktpwcRd+kn51WfjXZ5jeeWKXVrbodGlxI4
TeSOZpjWfw5JAnksn8rmMt3glcyI3JNLxnumMnCQSyPu0KD8XFf3sj57p0OIWVFv
/7v+dGjjs8Gui7cSYlqCFn0fnCZzQKGIMHiNLgzFiNPddcoEL++15gFXrt7+EZI9
Vw/yNRKQVrbrKd8IkAS7RPOIjE+/4Q/8AMYgAkQRzme/dLui4q/Ovqduus9FjLAf
PuwiDoFUFn/S4h4zGFGcjjrF+xHoZS/HvBE5C0TKJ+Tt+CTBXVB3kSlaWB4PZQcP
TsKE28suYrypKFVGEyeiCcjUD+zh0SITiZiNQMvun2BOuuJgBsRInyRyasoG7waI
RqDrECJaljsypevyO4C2
=CjWl
-----END PGP SIGNATURE-----
Reply to: