[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: l2tp-ipsec-vpn (updated package)



Hi Werner,

On Sat, Mar 10, 2012 at 03:28:28PM +0100, Werner Jaeger wrote:
> My sponsor is kilian@debian.org.
> 
> I just uploaded the new version 1.0.4-1 of my package "l2tp-ipsec-vpn".
[...]
> http://mentors.debian.net/debian/pool/main/l/l2tp-ipsec-vpn/l2tp-ipsec-vpn_1.0.4-1.dsc

following the lintian warning
W: l2tp-ipsec-vpn: possibly-insecure-handling-of-tmp-files-in-maintainer-script prerm:23

I'd like to ask you to explain a bit more about your motivation to move from
/var/run to /var/tmp. Of course /tmp can be used for sockets, but according
to [1] I'd say /var/tmp/ is not the right choice.

To me the old path looked much better: (see resources/getIPSecInfo.lib.tpl)
-exec 3</var/run/pluto/ipsec.info
+exec 3</var/tmp/L2tpIPsecVpn/defaultgateway.info

Even more I'd say your call to:
L2tpIPsecVpn deleteAllConfFiles || true
does absolutely not belong into the remove target, but into purge of postrm.

Further, as you've bumped to Standards-Version 3.9.3 you may also look into
bumping debian/copyright to the new official 1.0 Format.

Your debian/watch doesn't check out too btw..

[1]: http://www.pathname.com/fhs/2.2/fhs-5.15.html

-- 
Best regads,
Kilian

Attachment: signature.asc
Description: Digital signature


Reply to: