Bug#659822: RFS: mpd-sima/0.9.0-1 (New upstream version)

[Jakub Wilk <jwilk@debian.org>]

* Geoffroy Youri Berret <efrim@azylum.org>, 2012-02-17, 00:41:
> > - In debian/mpd-sima.postrm, you use awk but you don't Depend on it.
> Right, I replaced it with a “grep | cut” alternative.

While I personally don't like awk :P, but if you like it, you _can_ use 
it in maintainer scripts without depending on it. awk is (in a way) an 
essential package:
http://lists.debian.org/debian-mentors/2005/11/msg00193.html

I believe that lintian would yell at you if you had unversioned 
dependency on awk. (And versioned dependency on awk would render your 
package uninstallable. :P)

> > You're also checking if /usr/sbin/deluser is executable and silently 
> > not removing the user if it's not (same thing for delgroup). Since you 
> > Depend on adduser, you should assume these commands exist, and it 
> > should be an error visible to the user if they don't.
> Corrected as well.

Err. What Policy §6.5 says: “[…] all ‘postrm’ actions may only rely on 
essential packages and must gracefully skip any actions that require the 
package's dependencies if those dependencies are unavailable.”

So checking for existence of /usr/sbin/deluser _is_ the right thing if 
you want to use it. See this however:
http://lists.debian.org/debian-devel/2012/02/msg00094.html

> > - Regarding debian/wrappers, why not intall the python modules some 
> > place where python can find them by default?
> Well, these are not pure python modules but python applications. Hope I 
> got you right, but they are private module which should stay private 
> and should not get into python name space.

ACK

> Hence the shell wrappers.

I recommend to write such wrappers in Python, so that a user can run the 
software using non-default version easily.

Or even easier, just make /usr/bin/$something -> 
/usr/share/mpd-sima/$something symlinks.

> > And I think first line should read "#!/bin/sh", as outlined in debian 
> > policy 10.4.
> I guess I got confused by the python policy recommending a 
> "/usr/bin/env" sha-bang.

It's a very weak recommendation, if recommendtation at all. Python 
Policy §3.1 reads:

“Programs that can run with any version of Python must begin with 
#!/usr/bin/python or #!/usr/bin/env python (the former is strongly 
preferred).”

--
Jakub Wilk