Re: RFS: jailkit

[Jakub Wilk <jwilk@debian.org>]

* BjĂśrn Esser <bjoern.esser@googlemail.com>, 2011-11-10, 19:57:
>  http://mentors.debian.net/package/jailkit
>
> Alternatively, one can download the package with dget using this command:
>
>  dget -x
> http://mentors.debian.net/debian/pool/main/j/jailkit/jailkit_2.14-1.dsc

(I don't intend to sponsor this package.)

The package fails to build in a minimal environment:
|    dh_install
| cp: cannot stat `debian/tmp//usr/sbin/jk_procmailwrapper': No such file or directory
| dh_install: cp -a debian/tmp//usr/sbin/jk_procmailwrapper debian/jailkit///usr/sbin/ returned exit code 1

Lintian complains:
I: jailkit source: duplicate-long-description jailkit jailkit-common
W: jailkit source: format-3.0-but-debian-changes-patch
W: jailkit-common: manpage-has-errors-from-man usr/share/man/man8/jailkit.8.gz 73: warning: macro `Use' not defined
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jailkit.8.gz:110
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jailkit.8.gz:111
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jailkit.8.gz:112
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jailkit.8.gz:114
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_check.8.gz:16
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_check.8.gz:18
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_check.8.gz:20
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_check.8.gz:22
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_check.8.gz:75
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_check.8.gz:79
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_check.8.gz:83
I: jailkit-common: spelling-error-in-manpage usr/share/man/man8/jk_chrootlaunch.8.gz deamon daemon
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_chrootlaunch.8.gz:32
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_chrootlaunch.8.gz:66
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_cp.8.gz:18
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_cp.8.gz:22
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_init.8.gz:43
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_jailuser.8.gz:18
I: jailkit-common: spelling-error-in-manpage usr/share/man/man8/jk_jailuser.8.gz seperator separator
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_lsh.8.gz:12
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_socketd.8.gz:68
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_socketd.8.gz:71
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_socketd.8.gz:74
I: jailkit-common: hyphen-used-as-minus-sign usr/share/man/man8/jk_socketd.8.gz:84

Why do you build depend on python2.6-minimal and python-minimal?

debian/docs lists README.txt twice.

jailkit.postrm is kinda empty, just remove it.

jailkit's prerm removes /usr/share/jailkit/jk_lib.pyc, but 
/usr/share/jailkit/jk_lib.py is in the other package (jailkit-common). 
Anyway, python-support would take care of byte-compilation (and cleaning 
up after it) if used correctly...

Maybe more importantly, why jailkit and jailkit-common are separate 
packages?

"jk_list --help" doesn't quite work:
| # jk_list --help
| Traceback (most recent call last):
|   File "/usr/sbin/jk_list", line 156, in <module>
|     main()
|   File "/usr/sbin/jk_list", line 144, in main
|     usage()
| NameError: global name 'usage' is not defined

--
Jakub Wilk