Bug#648299: uscan; whitespace in filename

[Ansgar Burchardt <ansgar@debian.org>]

Package: devscripts
Version: 2.10.69

Mathieu Malaterre <mathieu.malaterre@gmail.com> writes:
>   Has anyone work with upstream tarball with a space in the filename ?
> I could get uscan to work (--verbose), however --repack fails
> miserably on the following file:
>
> http://anonscm.debian.org/viewvc/collab-maint/deb-maint/openmcdf/debian/watch?view=markup
>
>   with:
>
> unzip:  cannot find or open ../OpenMCDF, ../OpenMCDF.zip or ../OpenMCDF.ZIP.
> tar: 1.5.2.tar.gz: Cannot stat: No such file or directory
> tar: Exiting with failure status due to previous errors
> Repacking from zip to tar.gz failed
> make: *** [get-orig-source] Error 2

This seems to be a bug in uscan: it uses

  system("unzip -q -d $tempdir $destdir/$newfile_base; GZIP=-9 tar -C $tempdir -czf $destdir/$newfile_base_gz .") == 0

to call unzip.  As this involves a shell, it breaks if any of the
variables contains whitespace (or other problematic characters).

It should probably use a list instead of a scalar to avoid the shell.

Ansgar