Re: RFS: php-db-dataobject
On 10/23/2011 03:11 AM, David Hannequin wrote:
> dget -x http://mentors.debian.net/debian/pool/main/p/php-db-dataobject/php-db-dataobject_1.9.6-1.dsc
>
Hi,
What are your motivations for having this package in the archive?
Also, next time you have a PEAR package, please Cc: the
Debian PHP PEAR Maintainers <pkg-php-pear@lists.alioth.debian.org>.
Also, PEAR package are team maintained, it'd be great if you join the
packaging project on Alioth, and set the Maintainer: field as the list
(and you just as Uploaders:).
1/ debian/compat
Please use compatibility level 7 at least, and probably 8 would be
even better, since the package has never been in Debian.
2/ CDBS
Could you please switch your package to use the dh 8 short style,
and pkg-php-tools instead of CDBS?
3/ debian/copyright
Your copyright file is completely wrong. That alone is enough to
reject your package, unfortunately. First of all, you should put
the full of the PHP license 3.01 in it. Second, it'd be great if you
could use the DEP5 format:
dep.debian.net/deps/dep5/
I didn't check your other package, since I am guessing it will have
the same issues. Please let us review one package at a time, and
once that one is ok, we can move to the 2nd one.
4/ debian/control
There's no home page field.
Section should be php, not web
Also, your package creates an empty /usr/bin folder (as reported
by lintian) as well as usr/share/php/.registry/.channel.doc.php.net/.
Thomas Goirand (zigo)
Reply to: